Bug 238394

Summary: [WPE][GTK] Dist/distcheck targets fail due to Python error
Product: WebKit Reporter: Adrian Perez <aperez>
Component: Tools / TestsAssignee: Adrian Perez <aperez>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, mcatanzaro, pnormand, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=239596
Attachments:
Description Flags
Patch none

Adrian Perez
Reported 2022-03-25 15:08:17 PDT
Running “Tools/Scripts/build-webkit --wpe --makeargs=distcheck”: [9/10] Checking release tarball: wpewebkit-2.36.0.tar Traceback (most recent call last): File "/app/webkit/Tools/Scripts/make-dist", line 341, in <module> manifest = Manifest(arguments.manifest_filename, arguments.source_dir, arguments.build_dir, tarball_root) File "/app/webkit/Tools/Scripts/make-dist", line 150, in __init__ self.process_line(line) File "/app/webkit/Tools/Scripts/make-dist", line 188, in process_line self.add_directory(Directory(*self.get_source_and_tarball_paths_from_parts(parts))) File "/app/webkit/Tools/Scripts/make-dist", line 98, in __init__ self.files_in_version_control = self.list_files_in_version_control() File "/app/webkit/Tools/Scripts/make-dist", line 112, in list_files_in_version_control return out.rstrip('\n').split('\n') TypeError: a bytes-like object is required, not 'str'
Attachments
Patch (1.77 KB, patch)
2022-03-25 15:12 PDT, Adrian Perez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adrian Perez
Comment 1 2022-03-25 15:12:39 PDT
Created attachment 455801 [details] Patch
EWS
Comment 2 2022-03-26 02:18:29 PDT
Committed r291934 (248905@main): <https://commits.webkit.org/248905@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 455801 [details].
Radar WebKit Bug Importer
Comment 3 2022-03-26 02:19:18 PDT
<rdar://problem/90873463>
Note You need to log in before you can comment on or make changes to this bug.