Bug 238376

Summary: Drop duplicate isFiringEventListeners check in Node wrappers' isReachableFromOpaqueRoots()
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: BindingsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, darin, ggaren, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=238380
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2022-03-25 08:41:46 PDT
Drop duplicate isFiringEventListeners check Node wrapper's isReachableFromOpaqueRoots(). Those wrappers already call JSNodeOwner::isReachableFromOpaqueRoots() which already takes care of checking the isFiringEventListeners flag.
Attachments
Patch (3.19 KB, patch)
2022-03-25 08:44 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2022-03-25 08:44:06 PDT
Created attachment 455766 [details] Patch
Geoffrey Garen
Comment 2 2022-03-25 12:00:04 PDT
Comment on attachment 455766 [details] Patch r=me
EWS
Comment 3 2022-03-25 13:33:42 PDT
Committed r291883 (248882@main): <https://commits.webkit.org/248882@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 455766 [details].
Radar WebKit Bug Importer
Comment 4 2022-03-25 13:34:18 PDT
<rdar://problem/90854052>
Note You need to log in before you can comment on or make changes to this bug.