Bug 238365

Summary: Improve rebuilding of ruby subtrees
Product: WebKit Reporter: Frédéric Wang (:fredw) <fred.wang>
Component: Layout and RenderingAssignee: Frédéric Wang (:fredw) <fred.wang>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch none

Frédéric Wang (:fredw)
Reported 2022-03-24 23:43:07 PDT
Should better handle anonymous before/after nodes.
Attachments
Patch (5.21 KB, patch)
2022-03-24 23:54 PDT, Frédéric Wang (:fredw) 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (5.21 KB, patch)
2022-03-24 23:59 PDT, Frédéric Wang (:fredw) 		no flags
DetailsFormatted DiffDiff
Patch (11.42 KB, patch)
2022-03-25 01:25 PDT, Frédéric Wang (:fredw) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Frédéric Wang (:fredw)
Comment 1 2022-03-24 23:54:50 PDT
Created attachment 455731 [details] Patch
EWS
Comment 2 2022-03-24 23:56:12 PDT
Zalan Bujtas found in /Volumes/Data/worker/Commit-Queue/build/Source/WebCore/ChangeLog does not appear to be a valid reviewer according to contributors.json. /Volumes/Data/worker/Commit-Queue/build/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
Frédéric Wang (:fredw)
Comment 3 2022-03-24 23:59:14 PDT
Created attachment 455733 [details] Patch
Frédéric Wang (:fredw)
Comment 4 2022-03-25 01:20:38 PDT
Comment on attachment 455733 [details] Patch need to update test expectation
Frédéric Wang (:fredw)
Comment 5 2022-03-25 01:25:26 PDT
Created attachment 455738 [details] Patch
EWS
Comment 6 2022-03-25 02:17:02 PDT
Committed r291852 (248864@main): <https://commits.webkit.org/248864@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 455738 [details].
Radar WebKit Bug Importer
Comment 7 2022-03-25 02:18:15 PDT
<rdar://problem/90826382>
Note You need to log in before you can comment on or make changes to this bug.