Bug 238334

Summary: Do not use std::numeric_limits<float>::min() as the initial value to collect max values for glyph overflow
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, dbarton, ews-watchlist, fred.wang, mmaxfield, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

zalan
Reported 2022-03-24 10:23:56 PDT
It has the side effect of a "never empty glyph vertical overflow" ( ceilf(std::max(0, std::min)) -> 1px )
Attachments
Patch (2.75 KB, patch)
2022-03-24 10:34 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (73.99 KB, patch)
2022-03-25 06:12 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (75.17 KB, patch)
2022-04-07 15:03 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (78.76 KB, patch)
2022-04-08 05:42 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2022-03-24 10:34:38 PDT
Created attachment 455650 [details] Patch
Simon Fraser (smfr)
Comment 2 2022-03-24 11:33:18 PDT
Comment on attachment 455650 [details] Patch Is there a behavior change here? No tests change?
zalan
Comment 3 2022-03-24 12:17:14 PDT
(In reply to Simon Fraser (smfr) from comment #2) > Comment on attachment 455650 [details] > Patch > > Is there a behavior change here? No tests change? Yes, I am using EWS to collect the new baseline.
zalan
Comment 4 2022-03-25 06:12:00 PDT
Created attachment 455752 [details] Patch
Radar WebKit Bug Importer
Comment 5 2022-03-31 10:24:15 PDT
<rdar://problem/91111725>
zalan
Comment 6 2022-04-07 15:03:36 PDT
Created attachment 456973 [details] Patch
zalan
Comment 7 2022-04-08 05:42:46 PDT
Created attachment 457057 [details] Patch
EWS
Comment 8 2022-04-08 08:01:56 PDT
Committed r292606 (249438@main): <https://commits.webkit.org/249438@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 457057 [details].
Note You need to log in before you can comment on or make changes to this bug.