Bug 238326 – Add Captive Portal alert to WKWebView

• Component: WebKit2
• Status: RESOLVED FIXED

Add a Captive Portal alert in WKWebView

Created attachment 455643 [details]
Patch

[Geoffrey Garen]

Comment on attachment 455643 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455643&action=review

r=me

> Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm:1560
> +    [self _presentCaptivePortalModeAlertIfNeeded];

Views can move in and out of windows frequently, for example I believe they do so when switching tabs. I recommend double-checking that _presentCaptivePortalModeAlertIfNeeded is super efficient in the "do nothing" case.

Comment on attachment 455643 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455643&action=review

>> Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm:1560
>> +    [self _presentCaptivePortalModeAlertIfNeeded];
> 
> Views can move in and out of windows frequently, for example I believe they do so when switching tabs. I recommend double-checking that _presentCaptivePortalModeAlertIfNeeded is super efficient in the "do nothing" case.

Agreed. `_presentCaptivePortalModeAlertIfNeeded` should be efficient, especially for subsequent calls.

[Brent Fulgham]

Comment on attachment 455643 [details]
Patch

The iOS tests are failing for other patches -- I don't see how they are related to this change. Re-adding commit-queue.

[EWS]

Committed r291884 (248883@main): <https://commits.webkit.org/248883@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 455643 [details].

[Radar WebKit Bug Importer]

<rdar://problem/90854781>

[Simon Fraser (smfr)]

This broke the internal iOS build.

[WebKit Commit Bot]

Re-opened since this is blocked by bug 238405

[Brent Fulgham]

Comment on attachment 455643 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455643&action=review

> Source/WebKit/UIProcess/API/ios/WKWebViewIOS.h:28
> +#if USE(APPLE_INTERNAL_SDK) && PLATFORM(IOS_FAMILY)

I think this might avoid breaking the build:

#if USE(APPLE_INTERNAL_SDK) && PLATFORM(IOS_FAMILY) && __has_include(<WebKitAdditions/WKWebViewAdditions.h>)

[Brent Fulgham]

Created attachment 456048 [details]
Patch for landing

[EWS]

ChangeLog entry in Source/WebKit/ChangeLog contains OOPS!.

[Brent Fulgham]

Created attachment 456049 [details]
Patch for landing

[EWS]

Committed r292065 (248999@main): <https://commits.webkit.org/248999@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 456049 [details].