Bug 238252 – [Forms] Alias appearance <compat-auto> keywords to 'auto' for button

• Component: CSS
• Status: RESOLVED FIXED

We need to alias the <compat-auto> keywords 'auto' for button.

Created attachment 455488 [details]
Patch

Created attachment 455502 [details]
Patch

[Darin Adler]

Comment on attachment 455502 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455502&action=review

> Source/WebCore/ChangeLog:9
> +        handle some button ralted cases including button, push-button and square-button.

ralted -> related

> LayoutTests/fast/forms/file/file-style-inheritance.html:9
> -    /* Uses square-button for ease of testing on Mac. */
> -    -webkit-appearance: square-button;
> +    /* Uses none for ease of testing on Mac. */
> +    -webkit-appearance: none;

Does this still test what it intends to, given that it’s using "none" for appearance?

Created attachment 455504 [details]
Patch

(In reply to Darin Adler from comment #3)
> Comment on attachment 455502 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=455502&action=review
> 
> > Source/WebCore/ChangeLog:9
> > +        handle some button ralted cases including button, push-button and square-button.
> 
> ralted -> related
> 
> > LayoutTests/fast/forms/file/file-style-inheritance.html:9
> > -    /* Uses square-button for ease of testing on Mac. */
> > -    -webkit-appearance: square-button;
> > +    /* Uses none for ease of testing on Mac. */
> > +    -webkit-appearance: none;
> 
> Does this still test what it intends to, given that it’s using "none" for
> appearance?

I think so. The test is to check if "Choose File" button of a file upload control correctly inherit the style of the container input element, not focusing on the button type. Also moving "-webkit-appearance: square-button" to "-webkit-appearance: none" in Chromium was done by the original test writer.

Landing this patch. The failure in ios-wk2 doesn't look related.

[EWS]

Committed r291962 (248927@main): <https://commits.webkit.org/248927@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 455504 [details].

[Radar WebKit Bug Importer]

<rdar://problem/90917113>