Bug 238221

Summary: Add URL::stringWithoutFragmentIdentifier() overload which returns a String instead of a StringView
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Web Template FrameworkAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, benjamin, cmarcelo, darin, ews-watchlist, ggaren, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=236069
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2022-03-22 13:05:01 PDT
Add URL::stringWithoutFragmentIdentifier() overload which returns a String instead of a StringView.
Attachments
Patch (6.92 KB, patch)
2022-03-22 13:06 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2022-03-22 13:06:14 PDT
Created attachment 455419 [details] Patch
Geoffrey Garen
Comment 2 2022-03-22 16:37:10 PDT
Comment on attachment 455419 [details] Patch r=me
EWS
Comment 3 2022-03-22 17:59:55 PDT
Committed r291730 (248762@main): <https://commits.webkit.org/248762@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 455419 [details].
Radar WebKit Bug Importer
Comment 4 2022-03-22 18:00:21 PDT
<rdar://problem/90670425>
Alex Christensen
Comment 5 2022-03-22 20:01:48 PDT
What motivated this change?
Chris Dumez
Comment 6 2022-03-22 20:02:54 PDT
(In reply to Alex Christensen from comment #5) > What motivated this change? Review feedback from Darin here: https://bugs.webkit.org/show_bug.cgi?id=236069#c11
Note You need to log in before you can comment on or make changes to this bug.