Summary: | Move TextureMapper member variables, types and code out of GraphicsContextGLANGLE | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Zan Dobersek <zan> | ||||
Component: | WebGL | Assignee: | Zan Dobersek <zan> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | alex, cmarcelo, dino, ews-watchlist, Hironori.Fujii, kbr, kkinnunen, kondapallykalyan, luiz, webkit-bug-importer, zdobersek | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 237649 | ||||||
Attachments: |
|
Description
Zan Dobersek
2022-03-22 05:55:24 PDT
Created attachment 455364 [details]
Patch
Comment on attachment 455364 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=455364&action=review LGTM! Great refactor, just added a small comment. > Source/WebCore/platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.h:82 > +#if USE(COORDINATED_GRAPHICS) > + GCGLuint m_intermediateTexture { 0 }; > +#endif > + > +#if USE(NICOSIA) > + std::unique_ptr<Nicosia::GCGLANGLELayer> m_nicosiaLayer; Could we use remove of of the #ifs here and joing the two code sections? Comment on attachment 455364 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=455364&action=review >> Source/WebCore/platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.h:82 >> + std::unique_ptr<Nicosia::GCGLANGLELayer> m_nicosiaLayer; > > Could we use remove of of the #ifs here and joing the two code sections? I'm just moving code around, I'm not making these decisions ATM. Committed r291616 (248709@main): <https://commits.webkit.org/248709@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 455364 [details]. Does this change match Kimmo's plan (bug#236769 comment#0)? This one:
> The long-term plan would be to minimise the ifdefs in GraphicsContextGLANGLE.
It doesn't affect others.
|