Bug 238200 – Move TextureMapper member variables, types and code out of GraphicsContextGLANGLE

• Component: WebGL
• Status: RESOLVED FIXED

[Zan Dobersek]

Move TextureMapper member variables, types and code out of GraphicsContextGLANGLE

[Zan Dobersek]

Created attachment 455364 [details]
Patch

[Alejandro G. Castro]

Comment on attachment 455364 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455364&action=review

LGTM! Great refactor, just added a small comment.

> Source/WebCore/platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.h:82
> +#if USE(COORDINATED_GRAPHICS)
> +    GCGLuint m_intermediateTexture { 0 };
> +#endif
> +
> +#if USE(NICOSIA)
> +    std::unique_ptr<Nicosia::GCGLANGLELayer> m_nicosiaLayer;

Could we use remove of of the #ifs here and joing the two code sections?

[Zan Dobersek]

Comment on attachment 455364 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455364&action=review

>> Source/WebCore/platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.h:82
>> +    std::unique_ptr<Nicosia::GCGLANGLELayer> m_nicosiaLayer;
> 
> Could we use remove of of the #ifs here and joing the two code sections?

I'm just moving code around, I'm not making these decisions ATM.

[EWS]

Committed r291616 (248709@main): <https://commits.webkit.org/248709@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 455364 [details].

[Radar WebKit Bug Importer]

<rdar://problem/90635015>

[Fujii Hironori]

Does this change match Kimmo's plan (bug#236769 comment#0)?

[Zan Dobersek]

This one:
> The long-term plan would be to minimise the ifdefs in GraphicsContextGLANGLE.

It doesn't affect others.