Summary: | Add a debug overlay for interaction regions | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||||||||||
Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | annulen, cdumez, darin, dino, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jer.noble, kangil.han, philipj, ryuan.choi, sergio, webkit-bug-importer, wenson_hsieh | ||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Attachments: |
|
Description
Tim Horton
2022-03-21 22:41:10 PDT
Created attachment 455334 [details]
Patch
Created attachment 455345 [details]
Patch
Comment on attachment 455345 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=455345&action=review r=me (with a build fix for CMake) > Source/WebCore/dom/Node.cpp:2519 > + for (const auto& eventType : eventTypes()) { > + if (eventNames().isTouchRelatedEventType(eventType, *this)) > + return true; > + } > + return false; (Could consider using `containsIf` here — might be a tiny bit cleaner) > Source/WebCore/page/DebugPageOverlays.cpp:265 > + Vector<Setting> m_settings { FixedVector? > Source/WebCore/page/FrameSnapshotting.cpp:189 > + for (; !!renderer; renderer = renderer->parent()) { Could we use `ancestorsOfType<RenderElement>` here? > Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h:40 > + _WKInteractionRegion = 1 << 4, Does this need availability information too? Comment on attachment 455345 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=455345&action=review >> Source/WebCore/page/DebugPageOverlays.cpp:265 >> + Vector<Setting> m_settings { > > FixedVector? std::array? Created attachment 456285 [details]
Patch
Created attachment 456310 [details]
Patch
(In reply to Darin Adler from comment #5) > Comment on attachment 455345 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=455345&action=review > > >> Source/WebCore/page/DebugPageOverlays.cpp:265 > >> + Vector<Setting> m_settings { > > > > FixedVector? > > std::array? FixedVector seems like std::array with less steps? (unless we have another way to construct one from an initializer list without specifying the size?) (In reply to Wenson Hsieh from comment #4) > Comment on attachment 455345 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=455345&action=review > > r=me (with a build fix for CMake) > > > Source/WebCore/dom/Node.cpp:2519 > > + for (const auto& eventType : eventTypes()) { > > + if (eventNames().isTouchRelatedEventType(eventType, *this)) > > + return true; > > + } > > + return false; > > (Could consider using `containsIf` here — might be a tiny bit cleaner) Way cleaner! > > Source/WebCore/page/FrameSnapshotting.cpp:189 > > + for (; !!renderer; renderer = renderer->parent()) { > > Could we use `ancestorsOfType<RenderElement>` here? lineageOfType, apparently, so that we visit self. > > Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h:40 > > + _WKInteractionRegion = 1 << 4, > > Does this need availability information too? Of course! Comment on attachment 456310 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=456310&action=review > Source/WebCore/page/DebugPageOverlays.cpp:266 > + { "constrain", "Constrain to Regions", true }, Need a bunch of _s here if you don’t want to mess things up for Chris. (In reply to Darin Adler from comment #9) > Comment on attachment 456310 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=456310&action=review > > > Source/WebCore/page/DebugPageOverlays.cpp:266 > > + { "constrain", "Constrain to Regions", true }, > > Need a bunch of _s here if you don’t want to mess things up for Chris. I don't want to mess things up for Chris! I think I see what you're referring to. Created attachment 456322 [details]
Patch
Committed r292208 (249111@main): <https://commits.webkit.org/249111@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 456322 [details]. |