Bug 238160

Summary: It should be possible to copy text out of “AutoFilledAndViewable” password fields
Product: WebKit Reporter: Ricky Mondello <rmondello>
Component: FormsAssignee: Ricky Mondello <rmondello>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, ews-watchlist, ggaren, mifenton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
ggaren: review+
Patch ews-feeder: commit-queue-

Ricky Mondello
Reported 2022-03-21 15:59:58 PDT
It should be possible to copy text out of “AutoFilledAndViewable” password fields
Attachments
Patch (4.61 KB, patch)
2022-03-21 16:05 PDT, Ricky Mondello 		no flags
DetailsFormatted DiffDiff
Patch (4.60 KB, patch)
2022-03-21 16:07 PDT, Ricky Mondello 		no flags
DetailsFormatted DiffDiff
Patch (4.53 KB, patch)
2022-03-21 16:18 PDT, Ricky Mondello 		ggaren: review+
DetailsFormatted DiffDiff
Patch (4.47 KB, patch)
2022-03-21 16:45 PDT, Ricky Mondello 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Ricky Mondello
Comment 1 2022-03-21 16:05:12 PDT
Created attachment 455290 [details] Patch
Ricky Mondello
Comment 2 2022-03-21 16:07:39 PDT
Created attachment 455292 [details] Patch
Ricky Mondello
Comment 3 2022-03-21 16:18:13 PDT
Created attachment 455294 [details] Patch
Geoffrey Garen
Comment 4 2022-03-21 16:26:17 PDT
Comment on attachment 455294 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=455294&action=review r=me > Source/WebCore/editing/VisibleSelection.cpp:686 > +bool VisibleSelection::isInAutoFilledAndViewablePasswordField() const I think this helper function's usage would be more straight-forward if the function only computed "isInAutoFilledAndViewableField" and not also "isInPasswordField" -- since the caller already checks whether the selection is in a password field.
Ricky Mondello
Comment 5 2022-03-21 16:45:40 PDT
Created attachment 455299 [details] Patch
Ricky Mondello
Comment 6 2022-03-21 19:50:34 PDT
rdar://90541951
Radar WebKit Bug Importer
Comment 7 2022-03-21 19:50:55 PDT
<rdar://problem/90608844>
Geoffrey Garen
Comment 8 2022-03-22 08:49:26 PDT
Comment on attachment 455299 [details] Patch r=me
EWS
Comment 9 2022-03-22 09:02:40 PDT
Committed r291623 (248716@main): <https://commits.webkit.org/248716@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 455299 [details].
Note You need to log in before you can comment on or make changes to this bug.