Bug 238154 – [WebAuthn] Support getAssertion for virtual HID authenticators

• Component: WebKit Misc.
• Status: RESOLVED FIXED

[[e-mail]]

Virtual authenticators for WebAuthn support different transprots: nfc, usb, internal, and ble. Currently, we only fully support the internal transport and makeCredential for usb-transport. The default transport for web-platform-tests is usb. 

We should support getAssertion for the usb transport to run more WPT tests.

[Radar WebKit Bug Importer]

<rdar://problem/90593150>

[[e-mail]]

Created attachment 455276 [details]
Patch

[Brent Fulgham]

Comment on attachment 455276 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455276&action=review

r=me, but please correct the pass-by-value mistake.

> Source/WebCore/ChangeLog:9
> +        Virtual authenticators for WebAuthn support different transprots: nfc, usb, internal,

*transports

> Source/WebCore/Modules/webauthn/WebAuthenticationUtils.cpp:91
> +

Nit: Extra blank line here.

> Source/WebKit/UIProcess/WebAuthentication/Virtual/VirtualAuthenticatorManager.cpp:62
> +    VirtualCredential cred = credential;

Weird that you have to make this copy!

> Source/WebKit/UIProcess/WebAuthentication/Virtual/VirtualAuthenticatorManager.cpp:66
> +Vector<VirtualCredential> VirtualAuthenticatorManager::credentialsMatchingList(const String& authenticatorId, const String& rpId, Vector<Vector<uint8_t>> credentialIds)

credentialIds should be passed as a const& since you only read it.

> Source/WebKit/UIProcess/WebAuthentication/Virtual/VirtualAuthenticatorUtils.h:39
> +Vector<uint8_t> signatureForPrivateKey(RetainPtr<SecKeyRef> privateKey, const Vector<uint8_t>& authData, const Vector<uint8_t> clientDataHash);

clientDataHash should be a const referenced, not just a const vector.

[[e-mail]]

Created attachment 455293 [details]
Patch for landing

[EWS]

ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.

[[e-mail]]

Committed r291624 (?): <https://commits.webkit.org/r291624>

[[e-mail]]

*** Bug 237857 has been marked as a duplicate of this bug. ***