Summary: | [WebAuthn] Support getAssertion for virtual HID authenticators | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | pascoe <pascoe> | ||||||
Component: | WebKit Misc. | Assignee: | pascoe <pascoe> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bfulgham, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
pascoe@apple.com
2022-03-21 14:30:48 PDT
Created attachment 455276 [details]
Patch
Comment on attachment 455276 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=455276&action=review r=me, but please correct the pass-by-value mistake. > Source/WebCore/ChangeLog:9 > + Virtual authenticators for WebAuthn support different transprots: nfc, usb, internal, *transports > Source/WebCore/Modules/webauthn/WebAuthenticationUtils.cpp:91 > + Nit: Extra blank line here. > Source/WebKit/UIProcess/WebAuthentication/Virtual/VirtualAuthenticatorManager.cpp:62 > + VirtualCredential cred = credential; Weird that you have to make this copy! > Source/WebKit/UIProcess/WebAuthentication/Virtual/VirtualAuthenticatorManager.cpp:66 > +Vector<VirtualCredential> VirtualAuthenticatorManager::credentialsMatchingList(const String& authenticatorId, const String& rpId, Vector<Vector<uint8_t>> credentialIds) credentialIds should be passed as a const& since you only read it. > Source/WebKit/UIProcess/WebAuthentication/Virtual/VirtualAuthenticatorUtils.h:39 > +Vector<uint8_t> signatureForPrivateKey(RetainPtr<SecKeyRef> privateKey, const Vector<uint8_t>& authData, const Vector<uint8_t> clientDataHash); clientDataHash should be a const referenced, not just a const vector. Created attachment 455293 [details]
Patch for landing
ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. Committed r291624 (?): <https://commits.webkit.org/r291624> *** Bug 237857 has been marked as a duplicate of this bug. *** |