Bug 238084

Summary: [IFC][Integration] InlineIterator::Line::enclosingBottom should read enclosingBottomAdjustedForFollowingLine
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
[fast-cq]Patch
none
[fast-cq]Patch none

zalan
Reported 2022-03-18 10:52:56 PDT
ssia
Attachments
Patch (4.63 KB, patch)
2022-03-18 10:53 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (7.47 KB, patch)
2022-03-18 11:10 PDT, zalan 		no flags
DetailsFormatted DiffDiff
[fast-cq]Patch (7.47 KB, patch)
2022-03-18 12:31 PDT, zalan 		no flags
DetailsFormatted DiffDiff
[fast-cq]Patch (7.47 KB, patch)
2022-03-19 11:19 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2022-03-18 10:53:53 PDT
Created attachment 455111 [details] Patch
zalan
Comment 2 2022-03-18 11:10:41 PDT
Created attachment 455113 [details] Patch
Antti Koivisto
Comment 3 2022-03-18 11:32:36 PDT
Comment on attachment 455113 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=455113&action=review > Source/WebCore/layout/integration/InlineIteratorLine.h:99 > + LayoutUnit enclosingBottomAdjustedForFollowingLine() const; > LayoutUnit enclosingTopAdjustedForPrecedingLine() const; Top to the top!
zalan
Comment 4 2022-03-18 12:31:06 PDT
Created attachment 455126 [details] [fast-cq]Patch
zalan
Comment 5 2022-03-19 11:19:15 PDT
Created attachment 455168 [details] [fast-cq]Patch
EWS
Comment 6 2022-03-19 11:22:54 PDT
Committed r291529 (248635@main): <https://commits.webkit.org/248635@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 455168 [details].
Radar WebKit Bug Importer
Comment 7 2022-03-19 11:23:19 PDT
<rdar://problem/90526693>
Note You need to log in before you can comment on or make changes to this bug.