Bug 238074

Summary: Optimize AtomHTMLToken::initializeAttributes()
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, changseok, darin, esprehn+autocc, ews-watchlist, ggaren, gyuyoung.kim, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Chris Dumez 2022-03-18 07:28:32 PDT 
Optimize AtomHTMLToken::initializeAttributes().
Comment 1 Chris Dumez 2022-03-18 07:30:47 PDT 
Created attachment 455093 [details]
Patch
Comment 2 Geoffrey Garen 2022-03-18 08:42:47 PDT 
Comment on attachment 455093 [details]
Patch

R=me
Comment 3 Geoffrey Garen 2022-03-18 10:14:24 PDT 
Comment on attachment 455093 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455093&action=review

> Source/WebCore/html/parser/AtomHTMLToken.h:207
> +    HashSet<AtomString> addedAttributes;

Maybe reserveInitialCapacity(size) here, like we do for m_attributes?
Comment 4 Chris Dumez 2022-03-18 10:17:11 PDT 
Created attachment 455107 [details]
Patch
Comment 5 EWS 2022-03-18 17:20:40 PDT 
Committed r291508 (248615@main): <https://commits.webkit.org/248615@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 455107 [details].
Comment 6 Radar WebKit Bug Importer 2022-03-18 17:21:18 PDT 
<rdar://problem/90511727>