Bug 237998

Summary: [WebGPU] Mark unchanging class members as const
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: WebGPUAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, djg, kkinnunen, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch kkinnunen: review+

Myles C. Maxfield
Reported 2022-03-16 21:05:12 PDT
[WebGPU] Mark unchanging class members as const
Attachments
Patch (12.24 KB, patch)
2022-03-16 21:07 PDT, Myles C. Maxfield 		kkinnunen: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2022-03-16 21:07:21 PDT
Created attachment 454931 [details] Patch
Kimmo Kinnunen
Comment 2 2022-03-17 00:10:42 PDT
Comment on attachment 454931 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454931&action=review > Source/WebGPU/WebGPU/Adapter.h:58 > + const id<MTLDevice> m_device { nil }; const members don't need initialisers, as the compiler checks that all the constructors initialise the member
Myles C. Maxfield
Comment 3 2022-03-17 00:13:07 PDT
Comment on attachment 454931 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454931&action=review >> Source/WebGPU/WebGPU/Adapter.h:58 >> + const id<MTLDevice> m_device { nil }; > > const members don't need initialisers, as the compiler checks that all the constructors initialise the member I'd like to keep them because of this: https://bugs.webkit.org/show_bug.cgi?id=237437#c2
Myles C. Maxfield
Comment 4 2022-03-17 00:18:02 PDT
Committed r291389 (248519@trunk): <https://commits.webkit.org/248519@trunk>
Radar WebKit Bug Importer
Comment 5 2022-03-17 00:18:17 PDT
<rdar://problem/90415004>
Note You need to log in before you can comment on or make changes to this bug.