Bug 237993

Summary: compare-results should break down sync vs async time in Speedometer2
Product: WebKit Reporter: Saam Barati <saam>
Component: Tools / TestsAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, ashvayka, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
ashvayka: review+, ews-feeder: commit-queue-
[fast-cq] patch for landing
ews-feeder: commit-queue-
[fast-cq] patch for landing none

Saam Barati
Reported 2022-03-16 17:38:32 PDT
...
Attachments
patch (3.56 KB, patch)
2022-03-16 17:44 PDT, Saam Barati 		ashvayka: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
[fast-cq] patch for landing (3.50 KB, patch)
2022-03-17 10:50 PDT, Saam Barati 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
[fast-cq] patch for landing (3.50 KB, patch)
2022-03-17 13:07 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2022-03-16 17:44:06 PDT
Created attachment 454920 [details] patch
Alexey Shvayka
Comment 2 2022-03-16 18:29:29 PDT
Comment on attachment 454920 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=454920&action=review > Tools/Scripts/compare-results:77 > + #print(json.dumps(breakdown._results, indent=4, sort_keys=True)) nit: remove debug comment? > Tools/Scripts/compare-results:86 > + if not syncTime: nit: flip condition?
Saam Barati
Comment 3 2022-03-16 18:44:26 PDT
Comment on attachment 454920 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=454920&action=review >> Tools/Scripts/compare-results:77 >> + #print(json.dumps(breakdown._results, indent=4, sort_keys=True)) > > nit: remove debug comment? Yeah good point :-) >> Tools/Scripts/compare-results:86 >> + if not syncTime: > > nit: flip condition? I kinda like the ordering style wise now
Saam Barati
Comment 4 2022-03-17 10:50:53 PDT
Created attachment 454993 [details] [fast-cq] patch for landing
EWS
Comment 5 2022-03-17 11:31:19 PDT
Alexey Shvaika found in /Volumes/Data/worker/Commit-Queue/build/Tools/ChangeLog does not appear to be a valid reviewer according to contributors.json. /Volumes/Data/worker/Commit-Queue/build/Tools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
Saam Barati
Comment 6 2022-03-17 13:07:27 PDT
Created attachment 455010 [details] [fast-cq] patch for landing
EWS
Comment 7 2022-03-17 13:23:31 PDT
Committed r291436 (248560@main): <https://commits.webkit.org/248560@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 455010 [details].
Radar WebKit Bug Importer
Comment 8 2022-03-17 13:24:18 PDT
<rdar://problem/90449305>
Alexey Proskuryakov
Comment 9 2022-03-18 17:35:28 PDT
Silly question, what is "sync" and "async" here?
Note You need to log in before you can comment on or make changes to this bug.