Bug 237990

Summary: Expand autocorrect context for more accurate results.
Product: WebKit Reporter: Megan Gardner <megan_gardner>
Component: New BugsAssignee: Megan Gardner <megan_gardner>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, thorton, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 238476    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch for landing
none
Patch
none
Patch for landing none

Megan Gardner
Reported 2022-03-16 16:49:40 PDT
Expand autocorrect context for more accurate resutls.
Attachments
Patch (3.62 KB, patch)
2022-03-16 16:50 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch (3.65 KB, patch)
2022-03-16 16:50 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch (3.65 KB, patch)
2022-03-17 09:16 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch (3.82 KB, patch)
2022-03-17 15:37 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch (3.78 KB, patch)
2022-03-22 00:57 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch (3.08 KB, patch)
2022-03-22 00:58 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.88 KB, patch)
2022-03-22 13:30 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch (3.91 KB, patch)
2022-03-31 23:15 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.91 KB, patch)
2022-04-05 00:17 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Show Obsolete (8) View All Add attachment proposed patch, testcase, etc.
Megan Gardner
Comment 1 2022-03-16 16:50:06 PDT
Created attachment 454912 [details] Patch
Megan Gardner
Comment 2 2022-03-16 16:50:42 PDT
Created attachment 454913 [details] Patch
Megan Gardner
Comment 3 2022-03-16 16:51:10 PDT
rdar://87353381
Wenson Hsieh
Comment 4 2022-03-16 17:23:14 PDT
Comment on attachment 454913 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454913&action=review > Source/WebKit/ChangeLog:3 > + Expand autocorrect context for more accurate resutls. Nit - "results"
Megan Gardner
Comment 5 2022-03-17 09:16:07 PDT
Created attachment 454980 [details] Patch
Megan Gardner
Comment 6 2022-03-17 15:37:03 PDT
Created attachment 455037 [details] Patch
Tim Horton
Comment 7 2022-03-21 10:39:33 PDT
Comment on attachment 455037 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=455037&action=review I hit retry on the bot, let's see if that autocorrect test goes away. > Source/WebKit/ChangeLog:4 > + Expand autocorrect context to at least 10 words instead of 3, and with a min/max length of 40/100 instead of 12/30 > + and start context at the beginning of sentences to help with having more accurate autocorrect suggestions. This should be down where the description goes, the title should go here.
Megan Gardner
Comment 8 2022-03-22 00:57:51 PDT
Created attachment 455342 [details] Patch
Megan Gardner
Comment 9 2022-03-22 00:58:32 PDT
Created attachment 455343 [details] Patch
Megan Gardner
Comment 10 2022-03-22 13:30:06 PDT
Created attachment 455421 [details] Patch for landing
EWS
Comment 11 2022-03-22 17:12:54 PDT
Committed r291728 (248760@main): <https://commits.webkit.org/248760@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 455421 [details].
WebKit Commit Bot
Comment 12 2022-03-28 16:26:16 PDT
Re-opened since this is blocked by bug 238476
Megan Gardner
Comment 13 2022-03-31 23:15:23 PDT
Created attachment 456324 [details] Patch
Wenson Hsieh
Comment 14 2022-04-01 08:32:48 PDT
Comment on attachment 456324 [details] Patch r=mews
Megan Gardner
Comment 15 2022-04-05 00:17:35 PDT
Created attachment 456678 [details] Patch for landing
EWS
Comment 16 2022-04-05 01:37:15 PDT
Committed r292385 (249250@main): <https://commits.webkit.org/249250@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 456678 [details].
Note You need to log in before you can comment on or make changes to this bug.