Bug 237982

Summary: Calc() cleanup
Product: WebKit Reporter: Nikos Mouchtaris <nmouchtaris>
Component: CSSAssignee: Nikos Mouchtaris <nmouchtaris>
Status: RESOLVED FIXED    
Severity: Normal CC: esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, macpherson, menard, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Nikos Mouchtaris
Reported 2022-03-16 14:39:33 PDT
Cleanup due to addition of several math functions.
Attachments
Patch (8.02 KB, patch)
2022-03-16 14:46 PDT, Nikos Mouchtaris 		no flags
DetailsFormatted DiffDiff
Patch (6.32 KB, patch)
2022-03-17 16:37 PDT, Nikos Mouchtaris 		no flags
DetailsFormatted DiffDiff
Patch (7.78 KB, patch)
2022-03-17 17:04 PDT, Nikos Mouchtaris 		no flags
DetailsFormatted DiffDiff
Patch (8.01 KB, patch)
2022-03-17 17:31 PDT, Nikos Mouchtaris 		no flags
DetailsFormatted DiffDiff
Patch (7.04 KB, patch)
2022-03-18 12:26 PDT, Nikos Mouchtaris 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Nikos Mouchtaris
Comment 1 2022-03-16 14:46:04 PDT
Created attachment 454896 [details] Patch
Nikos Mouchtaris
Comment 2 2022-03-17 16:37:20 PDT
Created attachment 455043 [details] Patch
Nikos Mouchtaris
Comment 3 2022-03-17 17:04:41 PDT
Created attachment 455047 [details] Patch
Nikos Mouchtaris
Comment 4 2022-03-17 17:31:24 PDT
Created attachment 455053 [details] Patch
Simon Fraser (smfr)
Comment 5 2022-03-18 10:18:56 PDT
Comment on attachment 455053 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=455053&action=review > Source/WebCore/css/calc/CSSCalcOperationNode.cpp:76 > + default: The reason to not use `default` is that the compiler will warn you if you add a new enum value, but forget to add it to all the switch statements. > Source/WebCore/css/calc/CSSCalcOperationNode.cpp:146 > + default: Ditto.
Nikos Mouchtaris
Comment 6 2022-03-18 12:26:00 PDT
Created attachment 455125 [details] Patch
Nikos Mouchtaris
Comment 7 2022-03-18 12:31:39 PDT
(In reply to Simon Fraser (smfr) from comment #5) > Comment on attachment 455053 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=455053&action=review > > > Source/WebCore/css/calc/CSSCalcOperationNode.cpp:76 > > + default: > > The reason to not use `default` is that the compiler will warn you if you > add a new enum value, but forget to add it to all the switch statements. > > > Source/WebCore/css/calc/CSSCalcOperationNode.cpp:146 > > + default: > > Ditto. Yeah I didn't think that was necessary for these functions as they are only really used for the operators.
EWS
Comment 8 2022-03-18 18:00:20 PDT
Committed r291516 (248622@main): <https://commits.webkit.org/248622@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 455125 [details].
Radar WebKit Bug Importer
Comment 9 2022-03-18 18:01:17 PDT
<rdar://problem/90513089>
Note You need to log in before you can comment on or make changes to this bug.