Bug 23798

Summary: KURLGoogle needs support for protocolInHTTPFamily
Product: WebKit Reporter: David Levin <levin>
Component: PlatformAssignee: David Levin <levin>
Status: RESOLVED FIXED    
Severity: Normal CC: levin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch for bug.
eric: review-
Patch for bug.
none
Patch for bug. eric: review+

David Levin
Reported 2009-02-06 12:45:34 PST
This was added to KURL.h in http://trac.webkit.org/changeset/40553
Attachments
Patch for bug. (7.28 KB, patch)
2009-02-06 13:03 PST, David Levin 		eric: review-
DetailsFormatted DiffDiff
Patch for bug. (20.06 KB, patch)
2009-02-06 14:38 PST, David Levin 		no flags
DetailsFormatted DiffDiff
Patch for bug. (20.19 KB, patch)
2009-02-06 15:06 PST, David Levin 		eric: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
David Levin
Comment 1 2009-02-06 13:03:05 PST
Created attachment 27410 [details] Patch for bug.
Eric Seidel (no email)
Comment 2 2009-02-06 13:37:39 PST
Comment on attachment 27410 [details] Patch for bug. A comment make it easier to understand what lowerCaseEqualsASCII is doing. Especially in the last return. // The last char of str should be NULL if we reached the end or similar. It seems initProtocolInHTTPFamily should use: m_protocolInHTTPFamiy = m_isValid && (m_parsed.scheme.len == 4 && lowerCaseEqualsASCII(m_utf8.data(), m_utf8.data() + 4, "http") || ... That would be much shorter. :) Also, we should probably fix query_encoding to match WebKIt naming conventions while we're here. Otherwise looks fine.
David Levin
Comment 3 2009-02-06 14:38:39 PST
Created attachment 27420 [details] Patch for bug. I change the fixes slightly in response to your comments and added a comment as suggested. Also, since you suggested fixing a casingIssue, I did this throughout the file and fixed a few other style issues in the file.
David Levin
Comment 4 2009-02-06 15:06:57 PST
Created attachment 27421 [details] Patch for bug.
Eric Seidel (no email)
Comment 5 2009-02-06 15:16:51 PST
Comment on attachment 27421 [details] Patch for bug. r=me
Eric Seidel (no email)
Comment 6 2009-02-06 15:25:45 PST
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/platform/KURL.h M WebCore/platform/KURLGoogle.cpp M WebCore/platform/KURLGooglePrivate.h Committed r40735
Note You need to log in before you can comment on or make changes to this bug.