Bug 237974

Summary: [GTK][WPE] Guard libgbm and libdrm code, make them conditional dependencies for GTK
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: alex, annulen, cgarcia, ews-watchlist, gyuyoung.kim, ryuan.choi, sergio, webkit-bug-importer, zdobersek
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 237649    
Attachments:
Description Flags
Patch ews-feeder: commit-queue-

Zan Dobersek
Reported 2022-03-16 12:06:10 PDT
[GTK][WPE] Guard libgbm code, make it a conditional dependency for GTK
Attachments
Patch (9.00 KB, patch)
2022-03-16 12:17 PDT, Zan Dobersek 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2022-03-16 12:17:44 PDT
Created attachment 454878 [details] Patch
Alejandro G. Castro
Comment 2 2022-03-16 12:41:49 PDT
Comment on attachment 454878 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454878&action=review Great! LGTM! > Source/cmake/OptionsGTK.cmake:389 > + > + if (USE_ANGLE_WEBGL) > + find_package(GBM REQUIRED) > + find_package(LibDRM REQUIRED) > + SET_AND_EXPOSE_TO_BUILD(USE_LIBGBM TRUE) > + endif () I would add in the file a dependency, in case someone tries to force one and not the other, we are not planning to implement other option for ANGLE: WEBKIT_OPTION_DEPEND(USE_ANGLE_WEBGL USE_LIBGBM) > Source/cmake/OptionsWPE.cmake:285 > +SET_AND_EXPOSE_TO_BUILD(USE_LIBGBM TRUE) Ditto.
Zan Dobersek
Comment 3 2022-03-16 23:58:15 PDT
I missed the comment, I'll add them later.
EWS
Comment 4 2022-03-17 00:42:57 PDT
Committed r291392 (248522@main): <https://commits.webkit.org/248522@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 454878 [details].
Radar WebKit Bug Importer
Comment 5 2022-03-17 00:43:18 PDT
<rdar://problem/90415985>
Zan Dobersek
Comment 6 2022-03-17 03:00:49 PDT
Comment on attachment 454878 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454878&action=review >> Source/cmake/OptionsGTK.cmake:389 >> + endif () > > I would add in the file a dependency, in case someone tries to force one and not the other, we are not planning to implement other option for ANGLE: > > WEBKIT_OPTION_DEPEND(USE_ANGLE_WEBGL USE_LIBGBM) You can't force USE_LIBGBM, it's not public or configurable.
Note You need to log in before you can comment on or make changes to this bug.