Bug 237946

Summary: Only show notification permission prompt on user gesture
Product: WebKit Reporter: Ben Nham <nham>
Component: New BugsAssignee: Ben Nham <nham>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, ggaren, hi, mkwst, nham, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Ben Nham
Reported 2022-03-16 00:54:26 PDT
Only show notification permission prompt on user gesture
Attachments
Patch (31.51 KB, patch)
2022-03-16 00:56 PDT, Ben Nham 		no flags
DetailsFormatted DiffDiff
Patch (34.69 KB, patch)
2022-03-16 10:26 PDT, Ben Nham 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ben Nham
Comment 1 2022-03-16 00:56:00 PDT
Created attachment 454807 [details] Patch
Ben Nham
Comment 2 2022-03-16 00:58:10 PDT
rdar://88821287
Ben Nham
Comment 3 2022-03-16 10:26:54 PDT
Created attachment 454855 [details] Patch
Geoffrey Garen
Comment 4 2022-03-16 10:31:51 PDT
Comment on attachment 454855 [details] Patch r=me
EWS
Comment 5 2022-03-17 09:53:26 PDT
Committed r291414 (248542@main): <https://commits.webkit.org/248542@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 454855 [details].
Ben Nham
Comment 6 2022-03-17 12:08:35 PDT
This was also needed to fix an API test build failure on iOS: https://trac.webkit.org/changeset/291427/webkit/
Note You need to log in before you can comment on or make changes to this bug.