Bug 237946

Summary: Only show notification permission prompt on user gesture
Product: WebKit Reporter: Ben Nham <nham>
Component: New BugsAssignee: Ben Nham <nham>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, ggaren, hi, mkwst, nham, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Ben Nham 2022-03-16 00:54:26 PDT
Only show notification permission prompt on user gesture
Comment 1 Ben Nham 2022-03-16 00:56:00 PDT
Created attachment 454807 [details]
Patch
Comment 2 Ben Nham 2022-03-16 00:58:10 PDT
rdar://88821287
Comment 3 Ben Nham 2022-03-16 10:26:54 PDT
Created attachment 454855 [details]
Patch
Comment 4 Geoffrey Garen 2022-03-16 10:31:51 PDT
Comment on attachment 454855 [details]
Patch

r=me
Comment 5 EWS 2022-03-17 09:53:26 PDT
Committed r291414 (248542@main): <https://commits.webkit.org/248542@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 454855 [details].
Comment 6 Ben Nham 2022-03-17 12:08:35 PDT
This was also needed to fix an API test build failure on iOS:

https://trac.webkit.org/changeset/291427/webkit/