Bug 237928

Summary:	[PLT] base64StringForIconNameAndType might not be the best way to load media icons
Product:	WebKit	Reporter:	Justin Michaud <justin_michaud>
Component:	WebCore JavaScript	Assignee:	Justin Michaud <justin_michaud>
Status:	RESOLVED CONFIGURATION CHANGED
Severity:	Normal	CC:	eric.carlson, graouts, hi, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Local Build
Hardware:	Unspecified
OS:	Unspecified

Description Justin Michaud 2022-03-15 15:47:24 PDT

base64StringForIconNameAndType shows up as taking about 0.65% of the PLT5 score, so improvements here may be profitable.

Comment 1 Radar WebKit Bug Importer 2022-03-22 15:48:17 PDT

<rdar://problem/90663895>

Comment 2 Justin Michaud 2022-04-06 15:52:33 PDT

I ran a simple test by making the image loading asynchronous, and found that it was perf neutral. We can probably focus on removing the base64 encoding and possibly reducing the number of calls into JS. Hopefully this is an improvement, and we aren't just measuring the time taken to load the bundle from the file system.

Comment 3 Justin Michaud 2024-04-08 13:37:31 PDT

Closing old bugs assigned to me