Bug 237913

Summary: Make it clearer in the loading logging when it is for the main frame or not
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, esprehn+autocc, ews-watchlist, ggaren, japhet, kangil.han, kkinnunen, simon.fraser, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2022-03-15 12:20:41 PDT
Make it clearer in the loading logging when it is for the main frame or not.
Attachments
Patch (21.33 KB, patch)
2022-03-15 12:21 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (21.37 KB, patch)
2022-03-15 13:51 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2022-03-15 12:21:53 PDT
Created attachment 454740 [details] Patch
Alex Christensen
Comment 2 2022-03-15 13:49:46 PDT
Comment on attachment 454740 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454740&action=review > Source/WebCore/page/FrameView.cpp:147 > +#define FRAMEVIEW_RELEASE_LOG(channel, fmt, ...) RELEASE_LOG(channel, "%p - [pageID=%" PRIu64 ", frameID=%" PRIu64 ", isFrameFrame=%d] FrameView::" fmt, this, PAGE_ID, FRAME_ID, frame().isMainFrame(), ##__VA_ARGS__) isFrameFrame
Chris Dumez
Comment 3 2022-03-15 13:51:31 PDT
(In reply to Alex Christensen from comment #2) > Comment on attachment 454740 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=454740&action=review > > > Source/WebCore/page/FrameView.cpp:147 > > +#define FRAMEVIEW_RELEASE_LOG(channel, fmt, ...) RELEASE_LOG(channel, "%p - [pageID=%" PRIu64 ", frameID=%" PRIu64 ", isFrameFrame=%d] FrameView::" fmt, this, PAGE_ID, FRAME_ID, frame().isMainFrame(), ##__VA_ARGS__) > > isFrameFrame LOL, oops. thanks for catching.
Chris Dumez
Comment 4 2022-03-15 13:51:42 PDT
Created attachment 454754 [details] Patch
EWS
Comment 5 2022-03-15 16:17:12 PDT
Committed r291320 (248459@main): <https://commits.webkit.org/248459@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 454754 [details].
Radar WebKit Bug Importer
Comment 6 2022-03-15 16:18:33 PDT
<rdar://problem/90336857>
Note You need to log in before you can comment on or make changes to this bug.