Bug 237907

Summary: Fix logging in GPUProcessProxy::didCreateContextForVisibilityPropagation()
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: kkinnunen, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2022-03-15 10:37:15 PDT
Fix logging in GPUProcessProxy::didCreateContextForVisibilityPropagation().
Attachments
Patch (2.14 KB, patch)
2022-03-15 10:38 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2022-03-15 10:38:24 PDT
Created attachment 454727 [details] Patch
Simon Fraser (smfr)
Comment 2 2022-03-15 10:52:34 PDT
Comment on attachment 454727 [details] Patch Maybe we should add RELEASE_LOG_WITH_STREAM so you don't have to think about format strings.
Simon Fraser (smfr)
Comment 3 2022-03-15 10:52:59 PDT
Or does that not map to os_log?
Chris Dumez
Comment 4 2022-03-15 10:54:53 PDT
(In reply to Simon Fraser (smfr) from comment #2) > Comment on attachment 454727 [details] > Patch > > Maybe we should add RELEASE_LOG_WITH_STREAM so you don't have to think about > format strings. No idea because I don't know what RELEASE_LOG_WITH_STREAM is. If you talking about what the media code uses, no thanks. It requires subclassing and adding member functions.
EWS
Comment 5 2022-03-15 13:46:58 PDT
Committed r291311 (248450@main): <https://commits.webkit.org/248450@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 454727 [details].
Radar WebKit Bug Importer
Comment 6 2022-03-15 13:48:19 PDT
<rdar://problem/90328296>
Note You need to log in before you can comment on or make changes to this bug.