Bug 23787

Summary:

Allow JIT to generate SSE2 code if using GCC

Product:

WebKit

Reporter:

Csaba Osztrogonác <ossy>

Component:

JavaScriptCore

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

oliver

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

Attachments:

Description	Flags
6.6% progression on SunSpider	none
testing patch	none
proposed patch	none
proposed patch	none
proposed patch	oliver: review+
fixed patch	oliver: review+

Csaba Osztrogonác

Reported 2009-02-06 03:16:40 PST

In jit/JITArithmetic.cpp/isSSE2Present() haven't been implemented testing SSE2 capability if using GCC. Now it works, and patch attached.

Attachments
6.6% progression on SunSpider (3.90 KB, text/plain) 2009-02-06 03:18 PST, Csaba Osztrogonác	no flags	Details
testing patch (1.67 KB, patch) 2009-02-06 03:23 PST, Csaba Osztrogonác	no flags	Details Formatted Diff Diff
proposed patch (1.21 KB, patch) 2009-02-06 03:25 PST, Csaba Osztrogonác	no flags	Details Formatted Diff Diff
proposed patch (1.26 KB, patch) 2009-02-06 03:30 PST, Csaba Osztrogonác	no flags	Details Formatted Diff Diff
proposed patch (1.37 KB, patch) 2009-02-16 05:19 PST, Csaba Osztrogonác	oliver: review+	Details Formatted Diff Diff
fixed patch (1.43 KB, patch) 2009-02-17 02:14 PST, Csaba Osztrogonác	oliver: review+	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Csaba Osztrogonác

Comment 1 2009-02-06 03:18:09 PST

Created attachment 27386 [details] 6.6% progression on SunSpider

Csaba Osztrogonác

Comment 2 2009-02-06 03:23:33 PST

Created attachment 27387 [details] testing patch Use this patch for testing the new code. isSSE2Present() runs if JIT is enabled, but on x86 Linux it is diasbled at default.

Csaba Osztrogonác

Comment 3 2009-02-06 03:25:01 PST

Created attachment 27388 [details] proposed patch

Csaba Osztrogonác

Comment 4 2009-02-06 03:30:10 PST

Created attachment 27389 [details] proposed patch

Csaba Osztrogonác

Comment 5 2009-02-13 01:45:30 PST

(In reply to comment #2) > Created an attachment (id=27387) [review] > testing patch > > Use this patch for testing the new code. isSSE2Present() runs if JIT is > enabled, but on x86 Linux it is diasbled at default. This testing patch is unneccessary from http://trac.webkit.org/changeset/40900 if using QT4.5 RC1, because JIT and WREC are default.

Csaba Osztrogonác

Comment 6 2009-02-16 05:19:57 PST

Created attachment 27692 [details] proposed patch patch updated for ToT, and gcc guard added

Oliver Hunt

Comment 7 2009-02-16 14:15:51 PST

Committing to http://svn.webkit.org/repository/webkit/trunk ... M JavaScriptCore/ChangeLog M JavaScriptCore/jit/JITArithmetic.cpp Committed r41022

Mark Rowe (bdash)

Comment 8 2009-02-16 19:08:24 PST

This change broke the Qt and GTK builds and should be reverted. See <http://build.webkit.org/builders/trunk-qt-linux-release/builds/13583/steps/compile-release_2/logs/stdio> and <http://build.webkit.org/builders/trunk-gtk-linux-release/builds/3551/steps/compile-release/logs/stdio> for the errors.

Csaba Osztrogonác

Comment 9 2009-02-16 19:37:47 PST

I'll see this problem now, and try to fix.

Oliver Hunt

Comment 10 2009-02-16 19:40:03 PST

Rolled out in r41036 due to gtk+qt build failures.

Csaba Osztrogonác

Comment 11 2009-02-16 19:43:11 PST

I think this is a gcc bug, and push/pop ebx manually instead of mark clobbered can solve this problem.

Csaba Osztrogonác

Comment 12 2009-02-17 02:14:28 PST

Created attachment 27723 [details] fixed patch Build error fixed. If using -fPIC, ebx mustn't be in clobbered list, you have to save/restore it manually.

Oliver Hunt

Comment 13 2009-02-23 16:30:16 PST

Committing to http://svn.webkit.org/repository/webkit/trunk ... M JavaScriptCore/ChangeLog M JavaScriptCore/jit/JITArithmetic.cpp Committed r41160

Note You need to log in before you can comment on or make changes to this bug.