Bug 237869

Summary: [WebGPU] Implement queue submission methods according to the spec
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: WebGPUAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, djg, kkinnunen, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 237864    
Bug Blocks: 237583, 237870    
Attachments:
Description Flags
Patch
none
Patch kkinnunen: review+

Myles C. Maxfield
Reported 2022-03-14 20:01:38 PDT
.
Attachments
Patch (6.43 KB, patch)
2022-03-14 20:13 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (6.50 KB, patch)
2022-03-14 20:14 PDT, Myles C. Maxfield 		kkinnunen: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2022-03-14 20:13:22 PDT
Created attachment 454655 [details] Patch
Myles C. Maxfield
Comment 2 2022-03-14 20:14:41 PDT
Created attachment 454656 [details] Patch
Kimmo Kinnunen
Comment 3 2022-03-15 06:10:24 PDT
Comment on attachment 454656 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454656&action=review > Source/WebGPU/WebGPU/Queue.h:73 > + using OnSubmittedWorkDoneCallbacks = Vector<WTF::Function<void(WGPUQueueWorkDoneStatus)>>; completion handler aspect comes back also here. so later on, you perhaps should switch the onsubmitted api signature to use completion handler, as the. intention is to express "this function is valid only for one call".
Myles C. Maxfield
Comment 4 2022-03-16 14:20:11 PDT
Committed r291366 (248498@trunk): <https://commits.webkit.org/248498@trunk>
Radar WebKit Bug Importer
Comment 5 2022-03-16 14:21:17 PDT
<rdar://problem/90391949>
Myles C. Maxfield
Comment 6 2022-03-16 19:30:33 PDT
Committed r291382 (248513@trunk): <https://commits.webkit.org/248513@trunk>
Note You need to log in before you can comment on or make changes to this bug.