Bug 237821

Summary:

[AT-SPI] accessibility/native-text-control-attributed-string.html is failing

Product:

WebKit

Reporter:

Lauro Moura <lmoura>

Component:

New Bugs

Assignee:

Lauro Moura <lmoura>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, andresg_22, apinheiro, cfleizach, cgarcia, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=237820

Attachments:

Description	Flags
Patch	none
Patch with bugnumber	none
Updated patch skipping out of range	none
Patch for landing	none

Lauro Moura

Reported 2022-03-13 23:08:24 PDT

[AT-SPI] accessibility/native-text-control-attributed-string.html is failing

Attachments
Patch (11.18 KB, patch) 2022-03-13 23:09 PDT, Lauro Moura	no flags	Details Formatted Diff Diff
Patch with bugnumber (11.22 KB, patch) 2022-03-13 23:10 PDT, Lauro Moura	no flags	Details Formatted Diff Diff
Updated patch skipping out of range (8.04 KB, patch) 2022-03-24 20:11 PDT, Lauro Moura	no flags	Details Formatted Diff Diff
Patch for landing (8.13 KB, patch) 2022-03-28 13:52 PDT, Lauro Moura	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Lauro Moura

Comment 1 2022-03-13 23:09:01 PDT

Created attachment 454564 [details] Patch

Lauro Moura

Comment 2 2022-03-13 23:10:01 PDT

Created attachment 454565 [details] Patch with bugnumber

Lauro Moura

Comment 3 2022-03-13 23:14:26 PDT

Comment on attachment 454565 [details] Patch with bugnumber View in context: https://bugs.webkit.org/attachment.cgi?id=454565&action=review > LayoutTests/platform/gtk/accessibility/native-text-control-attributed-string-expected.txt:51 > +Attributed string for range (5, 10): In the mac expectation, this range has positions outside the string and ends up returning null. Should we do the same? > LayoutTests/platform/gtk/accessibility/native-text-control-attributed-string-expected.txt:66 > +Attributed string for range (10, 1): Ditto.

Carlos Garcia Campos

Comment 4 2022-03-15 06:37:42 PDT

Comment on attachment 454565 [details] Patch with bugnumber View in context: https://bugs.webkit.org/attachment.cgi?id=454565&action=review >> LayoutTests/platform/gtk/accessibility/native-text-control-attributed-string-expected.txt:51 >> +Attributed string for range (5, 10): > > In the mac expectation, this range has positions outside the string and ends up returning null. Should we do the same? Yes, for consistency. I guess we just need to check the range is valid and return null otherwise.

Radar WebKit Bug Importer

Comment 5 2022-03-20 23:09:18 PDT

<rdar://problem/90552509>

Lauro Moura

Comment 6 2022-03-24 20:11:56 PDT

Created attachment 455721 [details] Updated patch skipping out of range The -1,1 out of range case still returns an attribute string as the location arrives as 0, like in the mac port

Carlos Garcia Campos

Comment 7 2022-03-25 01:24:46 PDT

Comment on attachment 455721 [details] Updated patch skipping out of range View in context: https://bugs.webkit.org/attachment.cgi?id=455721&action=review > Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp:1169 > + auto text = m_element->text(); You should also move m_element->updateBackingStore(); here, before calling text().

Lauro Moura

Comment 8 2022-03-28 13:52:18 PDT

Created attachment 455949 [details] Patch for landing

EWS

Comment 9 2022-03-28 18:21:45 PDT

Committed r292019 (248963@main): <https://commits.webkit.org/248963@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 455949 [details].

Note You need to log in before you can comment on or make changes to this bug.