Bug 237810

Summary: [Mail compose] Allow copied resources with remote (HTTP/HTTPS) URLs to be pasted as attachments
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: HTML EditingAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: akeerthi, ews-watchlist, hi, katherine_cheney, megan_gardner, mifenton, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
For landing none

Wenson Hsieh
Reported 2022-03-12 14:05:26 PST
rdar://90119983
Attachments
Patch (7.81 KB, patch)
2022-03-12 14:36 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
For landing (7.83 KB, patch)
2022-03-14 14:34 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2022-03-12 14:36:43 PST
Created attachment 454541 [details] Patch
Devin Rousso
Comment 2 2022-03-14 14:15:52 PDT
Comment on attachment 454541 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454541&action=review r=me, neato :) > Source/WebCore/editing/cocoa/WebContentReaderCocoa.mm:209 > + return replacementType == ReplacementMethod::Attachment || !url.protocolIsInHTTPFamily(); NIT: I feel like this would read better as a separate if. ``` if (url.protocolIsInHTTPFamily()) return replacementType == ReplacementMethod::Attachment; return true; ```
Wenson Hsieh
Comment 3 2022-03-14 14:17:41 PDT
Comment on attachment 454541 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454541&action=review Thanks for the review! >> Source/WebCore/editing/cocoa/WebContentReaderCocoa.mm:209 >> + return replacementType == ReplacementMethod::Attachment || !url.protocolIsInHTTPFamily(); > > NIT: I feel like this would read better as a separate if. > ``` > if (url.protocolIsInHTTPFamily()) > return replacementType == ReplacementMethod::Attachment; > > return true; > ``` Sounds good — will change it to that.
Wenson Hsieh
Comment 4 2022-03-14 14:34:32 PDT
Created attachment 454622 [details] For landing
EWS
Comment 5 2022-03-14 18:56:23 PDT
Committed r291261 (248413@main): <https://commits.webkit.org/248413@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 454622 [details].
Note You need to log in before you can comment on or make changes to this bug.