Bug 237805

Summary: Enhance StackCheck debugging support and bump up the ASAN reserved zone size.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, ews-watchlist, pnormand, rmorisset, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch. none

Mark Lam
Reported 2022-03-11 23:48:49 PST
Patch coming.
Attachments
proposed patch. (13.53 KB, patch)
2022-03-12 00:27 PST, Mark Lam 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2022-03-12 00:27:31 PST
Created attachment 454529 [details] proposed patch.
Robin Morisset
Comment 2 2022-03-14 14:56:46 PDT
Comment on attachment 454529 [details] proposed patch. r=me, looks nice
Mark Lam
Comment 3 2022-03-14 14:57:56 PDT
Comment on attachment 454529 [details] proposed patch. Thanks for the review. Landing now.
EWS
Comment 4 2022-03-14 15:41:10 PDT
Committed r291255 (248407@main): <https://commits.webkit.org/248407@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 454529 [details].
Radar WebKit Bug Importer
Comment 5 2022-03-14 15:43:15 PDT
<rdar://problem/90273699>
Philippe Normand
Comment 6 2022-03-15 11:39:09 PDT
Comment on attachment 454529 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=454529&action=review > Source/WTF/wtf/StackCheck.h:77 > + reportVerificationFailureAndCrash(); Missing #if VERIFY_STACK_CHECK_RESERVED_ZONE_SIZE here?
Philippe Normand
Comment 7 2022-03-15 11:44:44 PDT
I think this broke CMake debug builds, StackCheck.cpp is not listed in the CMakeLists.txt of WTF. I'll send a follow-up patch.
Philippe Normand
Comment 8 2022-03-15 11:48:03 PDT
r291305
Mark Lam
Comment 9 2022-03-15 11:58:29 PDT
Comment on attachment 454529 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=454529&action=review >> Source/WTF/wtf/StackCheck.h:77 >> + reportVerificationFailureAndCrash(); > > Missing #if VERIFY_STACK_CHECK_RESERVED_ZONE_SIZE here? This entire block of code is under #if VERIFY_STACK_CHECK_RESERVED_ZONE_SIZE already.
Philippe Normand
Comment 10 2022-03-15 12:19:02 PDT
Comment on attachment 454529 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=454529&action=review >>> Source/WTF/wtf/StackCheck.h:77 >>> + reportVerificationFailureAndCrash(); >> >> Missing #if VERIFY_STACK_CHECK_RESERVED_ZONE_SIZE here? > > This entire block of code is under #if VERIFY_STACK_CHECK_RESERVED_ZONE_SIZE already. Right, I should have expanded the diff scope. Sorry
Note You need to log in before you can comment on or make changes to this bug.