Bug 237805

Summary: Enhance StackCheck debugging support and bump up the ASAN reserved zone size.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, ews-watchlist, pnormand, rmorisset, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch. none

Description Mark Lam 2022-03-11 23:48:49 PST 
Patch coming.
Comment 1 Mark Lam 2022-03-12 00:27:31 PST 
Created attachment 454529 [details]
proposed patch.
Comment 2 Robin Morisset 2022-03-14 14:56:46 PDT 
Comment on attachment 454529 [details]
proposed patch.

r=me, looks nice
Comment 3 Mark Lam 2022-03-14 14:57:56 PDT 
Comment on attachment 454529 [details]
proposed patch.

Thanks for the review.  Landing now.
Comment 4 EWS 2022-03-14 15:41:10 PDT 
Committed r291255 (248407@main): <https://commits.webkit.org/248407@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 454529 [details].
Comment 5 Radar WebKit Bug Importer 2022-03-14 15:43:15 PDT 
<rdar://problem/90273699>
Comment 6 Philippe Normand 2022-03-15 11:39:09 PDT 
Comment on attachment 454529 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=454529&action=review

> Source/WTF/wtf/StackCheck.h:77
> +                reportVerificationFailureAndCrash();

Missing #if VERIFY_STACK_CHECK_RESERVED_ZONE_SIZE here?
Comment 7 Philippe Normand 2022-03-15 11:44:44 PDT 
I think this broke CMake debug builds, StackCheck.cpp is not listed in the CMakeLists.txt of WTF. I'll send a follow-up patch.
Comment 8 Philippe Normand 2022-03-15 11:48:03 PDT 
r291305
Comment 9 Mark Lam 2022-03-15 11:58:29 PDT 
Comment on attachment 454529 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=454529&action=review

>> Source/WTF/wtf/StackCheck.h:77
>> +                reportVerificationFailureAndCrash();
> 
> Missing #if VERIFY_STACK_CHECK_RESERVED_ZONE_SIZE here?

This entire block of code is under #if VERIFY_STACK_CHECK_RESERVED_ZONE_SIZE already.
Comment 10 Philippe Normand 2022-03-15 12:19:02 PDT 
Comment on attachment 454529 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=454529&action=review

>>> Source/WTF/wtf/StackCheck.h:77
>>> +                reportVerificationFailureAndCrash();
>> 
>> Missing #if VERIFY_STACK_CHECK_RESERVED_ZONE_SIZE here?
> 
> This entire block of code is under #if VERIFY_STACK_CHECK_RESERVED_ZONE_SIZE already.

Right, I should have expanded the diff scope. Sorry