Bug 237787

Summary:

[Cocoa] MSE-backed videos fail to play in Captive Portal mode

Product:

WebKit

Reporter:

Jer Noble <jer.noble>

Component:

Media

Assignee:

Jer Noble <jer.noble>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

calvaris, eric.carlson, ews-watchlist, glenn, peng.liu6, philipj, sergio, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch for landing	ews-feeder: commit-queue-
Patch for landing	none
Patch for landing	none

Description Jer Noble 2022-03-11 10:24:58 PST

[Cocoa] MSE-backed videos fail to play in Captive Portal mode

Comment 1 Jer Noble 2022-03-11 10:25:49 PST

<rdar://89318047>

Comment 2 Jer Noble 2022-03-11 10:29:05 PST

Created attachment 454496 [details]
Patch

Comment 3 Jer Noble 2022-03-16 16:08:47 PDT

Created attachment 454907 [details]
Patch for landing

Comment 4 Peng Liu 2022-03-18 20:53:03 PDT

Comment on attachment 454907 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=454907&action=review

> Source/WebCore/ChangeLog:16
> +        Instead, use the FourCharCode class to properly create a string from the codec ID.

Nit. Looks like you mean `FourCC` here?

Comment 5 Jer Noble 2022-03-20 22:46:49 PDT

Created attachment 455217 [details]
Patch for landing

Comment 6 Jer Noble 2022-03-21 09:44:39 PDT

Comment on attachment 455217 [details]
Patch for landing

iOS-wk2 and api-mac tests are unrelated; cq+ing

Comment 7 EWS 2022-03-21 10:33:09 PDT

ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.

Comment 8 Jer Noble 2022-03-23 11:28:13 PDT

Created attachment 455529 [details]
Patch for landing

Comment 9 EWS 2022-03-23 13:02:17 PDT

Committed r291762 (248792@main): <https://commits.webkit.org/248792@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 455529 [details].