Bug 237784

Summary:

Finish implementing modify-headers actions for WKContentRuleList SPI

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

New Bugs

Assignee:

Alex Christensen <achristensen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Description Alex Christensen 2022-03-11 09:34:04 PST

Finish implementing modify-headers actions for WKContentRuleList SPI

Comment 1 Alex Christensen 2022-03-11 09:35:17 PST

Created attachment 454490 [details]
Patch

Comment 2 Alex Christensen 2022-03-11 09:35:21 PST

<rdar://problem/72433048>

Comment 3 Alex Christensen 2022-03-11 14:42:54 PST

Created attachment 454513 [details]
Patch

Comment 4 Timothy Hatcher 2022-03-11 15:14:56 PST

Comment on attachment 454513 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454513&action=review

> Source/WebCore/contentextensions/ContentExtensionActions.cpp:452
> +        return JSObjectGetPropertyForKey(context, toObject(value), JSValueMakeNumber(context, index), nullptr);

Can you use JSObjectGetPropertyAtIndex instead?

Comment 5 Alex Christensen 2022-03-11 15:21:49 PST

Created attachment 454515 [details]
Patch

Comment 6 EWS 2022-03-11 16:33:28 PST

Committed r291200 (248355@main): <https://commits.webkit.org/248355@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 454515 [details].