Bug 237784

Summary: Finish implementing modify-headers actions for WKContentRuleList SPI
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Alex Christensen
Reported 2022-03-11 09:34:04 PST
Finish implementing modify-headers actions for WKContentRuleList SPI
Attachments
Patch (16.39 KB, patch)
2022-03-11 09:35 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (19.74 KB, patch)
2022-03-11 14:42 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (19.70 KB, patch)
2022-03-11 15:21 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2022-03-11 09:35:17 PST
Created attachment 454490 [details] Patch
Alex Christensen
Comment 2 2022-03-11 09:35:21 PST
<rdar://problem/72433048>
Alex Christensen
Comment 3 2022-03-11 14:42:54 PST
Created attachment 454513 [details] Patch
Timothy Hatcher
Comment 4 2022-03-11 15:14:56 PST
Comment on attachment 454513 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454513&action=review > Source/WebCore/contentextensions/ContentExtensionActions.cpp:452 > + return JSObjectGetPropertyForKey(context, toObject(value), JSValueMakeNumber(context, index), nullptr); Can you use JSObjectGetPropertyAtIndex instead?
Alex Christensen
Comment 5 2022-03-11 15:21:49 PST
Created attachment 454515 [details] Patch
EWS
Comment 6 2022-03-11 16:33:28 PST
Committed r291200 (248355@main): <https://commits.webkit.org/248355@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 454515 [details].
Note You need to log in before you can comment on or make changes to this bug.