[Flatpak SDK] API tests scripts have conflicting parameters with the Flatpak scripts

• Component: WebKitGTK
• Status: RESOLVED FIXED

[Alejandro G. Castro]

run-gtk-tests and run-wpe-tests have arguments that cause conflict with the flatpak sdk, we have to rewrite and consume some of them to avoid problems because we do not know in those cases what the user is requesting, in general until we rewrite this script to a newer version we should always suggest to use the long format of the parameter name.

[Alejandro G. Castro]

Created attachment 454475 [details]
Patch

[Lauro Moura]

Comment on attachment 454475 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454475&action=review

> Tools/glib/api_test_runner.py:403
> +    for arg in sys.argv:

Shouldn't this be `argv` instead of `sys.argv`? (Happens to work in both scripts because we are already passing `sys.argv` as `argv`)

[Philippe Normand]

Comment on attachment 454475 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454475&action=review

>> Tools/glib/api_test_runner.py:403
>> +    for arg in sys.argv:
> 
> Shouldn't this be `argv` instead of `sys.argv`? (Happens to work in both scripts because we are already passing `sys.argv` as `argv`)

Right, good point Lauro!

[Alejandro G. Castro]

Thanks for the reviews! I'll upload a new patch.

[Alejandro G. Castro]

Created attachment 454580 [details]
Patch

[EWS]

Committed r291240 (248395@main): <https://commits.webkit.org/248395@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 454580 [details].