Bug 237778

Summary: [Flatpak SDK] API tests scripts have conflicting parameters with the Flatpak scripts
Product: WebKit Reporter: Alejandro G. Castro <alex>
Component: WebKitGTKAssignee: Alejandro G. Castro <alex>
Status: RESOLVED FIXED    
Severity: Normal CC: aperez, bugs-noreply, lmoura, pnormand
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Alejandro G. Castro
Reported 2022-03-11 05:46:12 PST
run-gtk-tests and run-wpe-tests have arguments that cause conflict with the flatpak sdk, we have to rewrite and consume some of them to avoid problems because we do not know in those cases what the user is requesting, in general until we rewrite this script to a newer version we should always suggest to use the long format of the parameter name.
Attachments
Patch (4.67 KB, patch)
2022-03-11 05:52 PST, Alejandro G. Castro 		no flags
DetailsFormatted DiffDiff
Patch (4.66 KB, patch)
2022-03-14 04:52 PDT, Alejandro G. Castro 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alejandro G. Castro
Comment 1 2022-03-11 05:52:32 PST
Created attachment 454475 [details] Patch
Lauro Moura
Comment 2 2022-03-11 08:39:10 PST
Comment on attachment 454475 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454475&action=review > Tools/glib/api_test_runner.py:403 > + for arg in sys.argv: Shouldn't this be `argv` instead of `sys.argv`? (Happens to work in both scripts because we are already passing `sys.argv` as `argv`)
Philippe Normand
Comment 3 2022-03-12 03:35:37 PST
Comment on attachment 454475 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454475&action=review >> Tools/glib/api_test_runner.py:403 >> + for arg in sys.argv: > > Shouldn't this be `argv` instead of `sys.argv`? (Happens to work in both scripts because we are already passing `sys.argv` as `argv`) Right, good point Lauro!
Alejandro G. Castro
Comment 4 2022-03-14 02:49:54 PDT
Thanks for the reviews! I'll upload a new patch.
Alejandro G. Castro
Comment 5 2022-03-14 04:52:35 PDT
Created attachment 454580 [details] Patch
EWS
Comment 6 2022-03-14 11:26:37 PDT
Committed r291240 (248395@main): <https://commits.webkit.org/248395@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 454580 [details].
Note You need to log in before you can comment on or make changes to this bug.