Bug 237748

Summary: Catalyst JavaScriptCore, WebCore, WebKitLegacy, and WebKit shouldn't be copied to the Secondary Path
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: PlatformAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal CC: david_quesada, dino, eric.carlson, ews-watchlist, hi, kbr, keith_miller, kondapallykalyan, mark.lam, pangle, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mark.lam: review+

Michael Saboff
Reported 2022-03-10 16:40:52 PST
I built a Mac Catalyst root and found that Mac Catalyst versions of JavaScriptCore, WebCore, WebKitLegacy, and WebKit were present in the secondary content path. These Catalyst frameworks shouldn’t be copied.
Attachments
Patch (15.20 KB, patch)
2022-03-10 16:53 PST, Michael Saboff 		mark.lam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2022-03-10 16:40:58 PST
<rdar://90127039>
Michael Saboff
Comment 2 2022-03-10 16:53:02 PST
Created attachment 454429 [details] Patch
EWS Watchlist
Comment 3 2022-03-10 16:54:50 PST
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Mark Lam
Comment 4 2022-03-10 16:57:26 PST
Comment on attachment 454429 [details] Patch rs=me
Mark Lam
Comment 5 2022-03-10 17:00:06 PST
Comment on attachment 454429 [details] Patch rs=me
Mark Lam
Comment 6 2022-03-10 17:01:06 PST
Comment on attachment 454429 [details] Patch rs=me
Michael Saboff
Comment 7 2022-03-10 17:21:00 PST
Committed r291139 (248299@trunk): <https://commits.webkit.org/248299@trunk>
Note You need to log in before you can comment on or make changes to this bug.