Bug 237744

Summary: Allow table of contents on posts in special cases
Product: WebKit Reporter: Jon Davis <jond>
Component: WebKit WebsiteAssignee: Jon Davis <jond>
Status: RESOLVED FIXED    
Severity: Normal CC: hi, jond, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Before applying patch
none
After applying patch
none
Patch none

Jon Davis
Reported 2022-03-10 16:20:53 PST
Add the ability to turn on table of contents generation for blog posts on webkit.org.
Attachments
Patch (3.20 KB, patch)
2022-03-10 16:30 PST, Jon Davis 		no flags
DetailsFormatted DiffDiff
Before applying patch (1.01 MB, image/png)
2022-03-10 16:30 PST, Jon Davis 		no flags
Details
After applying patch (1.06 MB, image/png)
2022-03-10 16:30 PST, Jon Davis 		no flags
Details
Patch (3.21 KB, patch)
2022-03-11 11:10 PST, Jon Davis 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jon Davis
Comment 1 2022-03-10 16:30:13 PST
Created attachment 454423 [details] Patch
Jon Davis
Comment 2 2022-03-10 16:30:41 PST
Created attachment 454424 [details] Before applying patch
Jon Davis
Comment 3 2022-03-10 16:30:58 PST
Created attachment 454425 [details] After applying patch
Devin Rousso
Comment 4 2022-03-10 16:42:46 PST
Comment on attachment 454423 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454423&action=review r=me > Websites/webkit.org/wp-content/plugins/table-of-contents.php:24 > + public static function tocEnabled ($post_type) { Style: I think we'd prefer something like `shouldEnableTableOfContents`, as future developers might not know what "toc" is 😅 Unless `'build-toc'` is some WordPress concept?
Jon Davis
Comment 5 2022-03-11 11:10:21 PST
Created attachment 454499 [details] Patch
Jon Davis
Comment 6 2022-03-11 11:11:30 PST
The follow-up patch has been changed to use `'build-table-of-contents'`.
EWS
Comment 7 2022-03-11 13:26:40 PST
Committed r291185 (248344@main): <https://commits.webkit.org/248344@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 454499 [details].
Radar WebKit Bug Importer
Comment 8 2022-03-11 13:27:21 PST
<rdar://problem/90177978>
Note You need to log in before you can comment on or make changes to this bug.