Bug 237620

Summary: Enable CFPrefs direct mode in adattributiond
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: pvollan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Alex Christensen 2022-03-08 15:05:32 PST 
Enable CFPrefs direct mode in adattributiond
Comment 1 Alex Christensen 2022-03-08 15:08:46 PST 
Created attachment 454155 [details]
Patch
Comment 2 Per Arne Vollan 2022-03-08 15:11:55 PST 
Comment on attachment 454155 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454155&action=review

Nice! R=me.

> Source/WebKit/Shared/EntryPointUtilities/Cocoa/Daemon/PCMDaemonEntryPoint.mm:135
> +        _CFPrefsSetDirectModeEnabled(YES);

You could also enable CF prefs read only mode (_CFPrefsSetReadOnly). Have the CF prefs services already been removed from the sandbox?
Comment 3 Alex Christensen 2022-03-08 15:15:05 PST 
Created attachment 454156 [details]
Patch
Comment 4 Alex Christensen 2022-03-08 15:23:45 PST 
Comment on attachment 454156 [details]
Patch

They were never added to the sandbox, which is how I found this problem.
Comment 5 EWS 2022-03-08 16:54:00 PST 
Committed r291021 (248195@main): <https://commits.webkit.org/248195@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 454156 [details].
Comment 6 Radar WebKit Bug Importer 2022-03-08 16:54:21 PST 
<rdar://problem/89998171>