Summary: | Use two-arg KURL constructor | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Xan Lopez <xan.lopez> | ||||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | ||||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | Linux | ||||||||
Attachments: |
|
Description
Xan Lopez
2009-02-05 08:50:44 PST
Created attachment 27351 [details]
Uso two-arg KURL ctor
Comment on attachment 27351 [details] Uso two-arg KURL ctor r=me > - SubstituteData substituteData(sharedBuffer.release(), contentMimeType ? String(contentMimeType) : "text/html", contentEncoding ? String(contentEncoding) : "UTF-8", KURL("about:blank"), url); > + SubstituteData substituteData(sharedBuffer.release(), contentMimeType ? String(contentMimeType) : "text/html", contentEncoding ? String(contentEncoding) : "UTF-8", KURL(KURL(), "about:blank"), url); I think that about:blank can be left as is - KURL parsing clearly won't affect it. Not that it matters much. (In reply to comment #2) > > - SubstituteData substituteData(sharedBuffer.release(), contentMimeType ? String(contentMimeType) : "text/html", contentEncoding ? String(contentEncoding) : "UTF-8", KURL("about:blank"), url); > > + SubstituteData substituteData(sharedBuffer.release(), contentMimeType ? String(contentMimeType) : "text/html", contentEncoding ? String(contentEncoding) : "UTF-8", KURL(KURL(), "about:blank"), url); > > I think that about:blank can be left as is - KURL parsing clearly won't affect > it. Not that it matters much. Or this could use the blankURL() function from KURL.h. Created attachment 27364 [details]
kurl.patch
Use blankURL() for 'about:blank'. Great suggestion, thanks!
Committed revision 40715. |