Bug 237581 – prepare-ChangeLog does not include Swift functions which contain local vars

• Component: New Bugs
• Status: RESOLVED FIXED

prepare-ChangeLog does not include Swift functions which contain local vars

Once the parser matches a variable or function it loses reference to any current function it was tracking. So when a function defines a local var, the var is matched and the containing function is lost.

For example:

1 class SomeClass {
2     func aClassMethod() {
3         var local: Local
4     }
5 }

Changes to aClassMethod will never cause (SomeClass.aClassMethod) in the ChangeLog because the range of [3, 3, local] is recorded instead.

[Radar WebKit Bug Importer]

<rdar://problem/89948275>

Created attachment 454073 [details]
Ignore nested function and var matches

[David Kilzer (:ddkilzer)]

Comment on attachment 454073 [details]
Ignore nested function and var matches

r=me

[David Kilzer (:ddkilzer)]

OH.  This patch is old enough that it still includes a ChangeLog file, but it's not supposed to include that anymore.

[David Kilzer (:ddkilzer)]

Created attachment 460877 [details]
Patch for landing sans ChangeLog

[David Kilzer (:ddkilzer)]

Comment on attachment 460877 [details]
Patch for landing sans ChangeLog

I seem to have broke the commit queue script with this patch.  :|

[David Kilzer (:ddkilzer)]

Tracking a fix for the commit queue:

Bug 242735 Submitted: Commit queue fails to land patch with changes to prepare-ChangeLog script

[David Kilzer (:ddkilzer)]

Waiting for the commit queue bot(s) to be updated/restarted to pick up the fix from Bug 242735 before this patch can land.

[David Kilzer (:ddkilzer)]

(In reply to David Kilzer (:ddkilzer) from comment #8)
> Waiting for the commit queue bot(s) to be updated/restarted to pick up the
> fix from Bug 242735 before this patch can land.

UGH.  Still getting the same error message as before:

>   File "/var/buildbot/OpenSource/Tools/CISupport/ews-build/steps.py", line 4919, in _files
>     match = re.search(self.RE_CHANGELOG, line)
>   File "/usr/lib64/python3.6/re.py", line 182, in search
>     return _compile(pattern, flags).search(string)
builtins.TypeError: cannot use a string pattern on a bytes-like object

I'm not sure how to fix that.

[EWS]

Committed 252573@main (8e82c35b8f05): <https://commits.webkit.org/252573@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 460877 [details].