Bug 237530

Summary: Make "true" count as truthy in window.open()'s boolean features
Product: WebKit Reporter: Domenic Denicola <d>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, changseok, clopez, darin, esprehn+autocc, ews-watchlist, ggaren, gyuyoung.kim, heycam, mifenton, sam, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Domenic Denicola 2022-03-07 07:00:45 PST 
See https://github.com/whatwg/html/pull/7425
Comment 1 Chris Dumez 2022-03-07 08:19:16 PST 
Created attachment 453988 [details]
Patch
Comment 2 Alex Christensen 2022-03-07 11:14:50 PST 
Comment on attachment 453988 [details]
Patch

"true" is the truthiest of words.
Comment 3 EWS 2022-03-07 11:22:35 PST 
Committed r290899 (248130@main): <https://commits.webkit.org/248130@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 453988 [details].
Comment 4 Radar WebKit Bug Importer 2022-03-07 11:23:18 PST 
<rdar://problem/89919539>
Comment 5 Cameron McCormack (:heycam) 2022-03-08 11:58:56 PST 
Reopening to attach new patch.
Comment 6 Cameron McCormack (:heycam) 2022-03-08 11:59:00 PST 
Created attachment 454139 [details]
Patch
Comment 7 Cameron McCormack (:heycam) 2022-03-08 12:00:43 PST 
Comment on attachment 454139 [details]
Patch

Bad ChangeLog position made webkit-patch upload to the wrong bug.