Bug 237490 – [XCBuild] Fix GeneratedSources dependency validation errors

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Elliott Williams]

There are some miscellaneous task dependencies, mostly coming from DerivedSources Makefiles which do not declare everything the use or generate.

[Elliott Williams]

Created attachment 454298 [details]
Patch

[Elliott Williams]

(In reply to Elliott Williams from comment #1)
> Created attachment 454298 [details]
> Patch

There are still some dependency errors I'm seeing above WebCore, in WebKit and WebKitLegacy. But this is a large enough set of changes that it's probably time to get it reviewed.

[Alexey Proskuryakov]

Comment on attachment 454298 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454298&action=review

This is already too long for me to deeply review all parts, but it looks fine.

> Tools/ChangeLog:1
> [phone]  Elliott Williams  <[e-mail]>

Duplicate ChangeLog.

[EWS]

ChangeLog entry in Tools/ChangeLog contains OOPS!.

[Elliott Williams]

Created attachment 454313 [details]
Patch

[Elliott Williams]

(In reply to Alexey Proskuryakov from comment #3)
> > Tools/ChangeLog:1
> > [phone]  Elliott Williams  <[e-mail]>
> 
> Duplicate ChangeLog.

Thanks -- fixed in the latest patch, and added your approval. I'll this without additional review.

[Elliott Williams]

It's worth noting that testing this patch on EWS broke subsequent EWS builds: Because this patch adds `JSCBuiltins.cpp` as an output file, the EWS builder thinks that the next patch it builds _removes_ JSCBuiltins.cpp, and will helpfully delete it as a stale build product.

For example, after building this patch in <https://ews-build.webkit.org/#/builders/61/builds/29660>, the next job <https://ews-build.webkit.org/#/builders/61/builds/29661> failed with:

    UnifiedSource2.cpp:2:10: fatal error: 'JSCBuiltins.cpp' file not found

Higher up in the build log, you see:

	Remove stale build products
	    /bin/rm -rf /Volumes/Data/worker/macOS-AppleSilicon-Big-Sur-Debug-Build-EWS/build/WebKitBuild/Debug/DerivedSources/JavaScriptCore/JSCBuiltins.cpp



I don't think there's anything worth fixing here. One of the goals of my work is to make it harder to forget to declare an output edge like this, requiring fewer bugfix patches like these that confuse EWS.

[EWS]

Committed r291133 (248293@main): <https://commits.webkit.org/248293@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 454313 [details].

[Radar WebKit Bug Importer]

<rdar://problem/90121847>