Bug 237465

Summary: [GTK][WPE] Documentation for webkit_web_context_set_spell_checking_languages() is incomplete
Product: WebKit Reporter: Adrian Perez <aperez>
Component: WebKit APIAssignee: Adrian Perez <aperez>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, mcatanzaro, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Adrian Perez
Reported 2022-03-04 02:16:23 PST
The API documentation for webkit_web_context_set_spell_checking_languages() only mentions that it affects the Accept-Language header in requests, but says nothing about navigator.language(s) and the Intl default locale, which are also affected by it because in the end using the function results in a call to WTF::overrideUserPreferredLanguages().
Attachments
Patch (2.00 KB, patch)
2022-03-04 02:19 PST, Adrian Perez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adrian Perez
Comment 1 2022-03-04 02:17:32 PST
One could also argue that the function should not receive a WebKitWebContext because it operates on a global setting, but let's just document all the implications for now and leave that for another bug ;-)
Adrian Perez
Comment 2 2022-03-04 02:19:28 PST
Created attachment 453824 [details] Patch
EWS
Comment 3 2022-03-04 03:38:26 PST
Committed r290825 (248061@main): <https://commits.webkit.org/248061@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 453824 [details].
Radar WebKit Bug Importer
Comment 4 2022-03-04 03:39:15 PST
<rdar://problem/89806783>
Note You need to log in before you can comment on or make changes to this bug.