Bug 237456

Summary: [Cocoa] Crash in MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Description Eric Carlson 2022-03-03 16:46:40 PST 
Sometimes see a crash in MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL when creating an AtomString from a compile-time const char*
Comment 1 Eric Carlson 2022-03-03 16:46:59 PST 
rdar://80407863
Comment 2 Eric Carlson 2022-03-03 17:05:22 PST 
Created attachment 453797 [details]
Patch
Comment 3 Eric Carlson 2022-03-03 17:12:26 PST 
Created attachment 453799 [details]
Patch
Comment 4 Jer Noble 2022-03-03 17:15:49 PST 
Comment on attachment 453799 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453799&action=review

> Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:1082
> +bool MediaPlayerPrivateAVFoundation::enableInheritURIQueryComponent() const

Nit: maybe shouldEnableInheritURIQueryComponent()?
Comment 5 Eric Carlson 2022-03-03 17:31:04 PST 
Created attachment 453801 [details]
Patch for landing
Comment 6 EWS 2022-03-04 10:47:30 PST 
Committed r290837 (248073@main): <https://commits.webkit.org/248073@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 453801 [details].