| Summary: | [JSC] Improve reuse of known register values on ARMv7 | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Angelos Oikonomopoulos <angelos> | ||||||||
| Component: | New Bugs | Assignee: | Angelos Oikonomopoulos <angelos> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | ews-watchlist, glore, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki, zan, zdobersek | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Angelos Oikonomopoulos
2022-03-03 06:46:24 PST
Created attachment 453731 [details]
Patch
Comment on attachment 453731 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=453731&action=review > Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h:2482 > + bool absoluteAddressWithinShortOffset(AbsoluteAddress address, CachedTempRegister &cachedRegister, int32_t &offset) Reference ampersands stick to the left. Maybe this could pack the offset value into a return std::optional<int32_t>. (In reply to Zan Dobersek from comment #2) > Comment on attachment 453731 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=453731&action=review > > > Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h:2482 > > + bool absoluteAddressWithinShortOffset(AbsoluteAddress address, CachedTempRegister &cachedRegister, int32_t &offset) > > Reference ampersands stick to the left. Maybe this could pack the offset > value into a return std::optional<int32_t>. Good point. I was just following the style of CachedTempRegister.value(), but I guess that predates the adoption of C++17 in the source. Created attachment 453826 [details]
Patch
Zan Dobersek found in /Volumes/Data/worker/Commit-Queue/build/Source/JavaScriptCore/ChangeLog does not appear to be a valid reviewer according to contributors.json. /Volumes/Data/worker/Commit-Queue/build/Source/JavaScriptCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Created attachment 453827 [details]
Patch
Committed r290828 (248064@main): <https://commits.webkit.org/248064@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 453827 [details]. |