Bug 237413

Summary: Simplify pseudo element resolution
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CSSAssignee: Antti Koivisto <koivisto>
Status: RESOLVED FIXED    
Severity: Normal CC: changseok, esprehn+autocc, ews-watchlist, glenn, graouts, kondapallykalyan, pdr, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 237362    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch for landing none

Description Antti Koivisto 2022-03-03 02:26:50 PST 
We can add pseudo element styles directly to their parent style instead of having a separate map for that.
Comment 1 Antti Koivisto 2022-03-03 02:28:29 PST 
Created attachment 453713 [details]
Patch
Comment 2 Antti Koivisto 2022-03-03 04:31:30 PST 
Created attachment 453719 [details]
Patch
Comment 3 Antti Koivisto 2022-03-03 05:28:42 PST 
Created attachment 453724 [details]
Patch
Comment 4 Antti Koivisto 2022-03-03 06:05:31 PST 
Created attachment 453725 [details]
Patch
Comment 5 Antoine Quint 2022-03-03 07:44:48 PST 
Comment on attachment 453725 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453725&action=review

> Source/WebCore/ChangeLog:64
> +

You probably want to merge the two ChangeLog entries.

> Source/WebCore/rendering/style/RenderStyle.cpp:116
> +    auto newStyle = RenderStyle(style, Clone);

I have a question reading this code: do we prefer this to the more compact `RenderStyle newStyle(style, Clone)`?
Comment 6 EWS 2022-03-03 07:55:56 PST 
ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.
Comment 7 Antti Koivisto 2022-03-03 08:12:06 PST 
Created attachment 453743 [details]
Patch for landing
Comment 8 Antti Koivisto 2022-03-03 08:12:59 PST 
> > +    auto newStyle = RenderStyle(style, Clone);
> 
> I have a question reading this code: do we prefer this to the more compact
> `RenderStyle newStyle(style, Clone)`?

I don't think there is policy on this but I feel it often reads better like this.
Comment 9 EWS 2022-03-03 09:25:26 PST 
Committed r290779 (248023@main): <https://commits.webkit.org/248023@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 453743 [details].
Comment 10 Radar WebKit Bug Importer 2022-03-03 09:26:19 PST 
<rdar://problem/89758898>