Bug 237393

Summary:

REGRESSION (r290512): imported/blink/fast/table/crash-output-element-as-column-group.html asserts sometimes

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

Tables

Assignee:

alan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, changseok, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

Safari Technology Preview

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=237205

Attachments:

Description	Flags
Patch	none

Simon Fraser (smfr)

Reported 2022-03-02 15:03:15 PST

https://ews-build.s3-us-west-2.amazonaws.com/macOS-AppleSilicon-Big-Sur-Debug-WK2-Tests-EWS/453636-25481/results.html ASSERTION FAILED: span >= 1 ./rendering/RenderTable.cpp(1045) : WebCore::RenderTableCol *WebCore::RenderTable::slowColElement(unsigned int, bool *, bool *) const 1 0x13c75426c WTFCrash 2 0x1172b6870 WebCore::JSDOMGlobalObject* JSC::jsCast<WebCore::JSDOMGlobalObject*, JSC::JSGlobalObject>(JSC::JSGlobalObject*) 3 0x11bf6e9b8 WebCore::RenderTable::slowColElement(unsigned int, bool*, bool*) const 4 0x11bc63588 WebCore::RenderTable::colElement(unsigned int, bool*, bool*) const 5 0x11bc5a484 WebCore::RenderTableCell::styleOrColLogicalWidth() const 6 0x11bd5e5d8 WebCore::RenderBlockFlow::computeIntrinsicLogicalWidths(WebCore::LayoutUnit&, WebCore::LayoutUnit&) const 7 0x11bd54844 WebCore::RenderBlock::computePreferredLogicalWidths() 8 0x11bf82ae4 WebCore::RenderTableCell::computePreferredLogicalWidths() 9 0x11bd7852c WebCore::RenderBox::minPreferredLogicalWidth() const 10 0x11bc59c64 WebCore::AutoTableLayout::recalcColumn(unsigned int) 11 0x11bc5ad90 WebCore::AutoTableLayout::fullRecalc() 12 0x11bc5afe0 WebCore::AutoTableLayout::computeIntrinsicLogicalWidths(WebCore::LayoutUnit&, WebCore::LayoutUnit&, WebCore::TableIntrinsics) 13 0x11bf6d33c WebCore::RenderTable::computeIntrinsicLogicalWidths(WebCore::LayoutUnit&, WebCore::LayoutUnit&, WebCore::TableIntrinsics) const 14 0x11bf6d378 WebCore::RenderTable::computeIntrinsicLogicalWidths(WebCore::LayoutUnit&, WebCore::LayoutUnit&) const 15 0x11bf6d438 WebCore::RenderTable::computePreferredLogicalWidths() 16 0x11bd785ac WebCore::RenderBox::maxPreferredLogicalWidth() const 17 0x11bf69270 WebCore::RenderTable::updateLogicalWidth() 18 0x11bf6a794 WebCore::RenderTable::layout() 19 0x11bd628b0 WebCore::RenderBlockFlow::layoutBlockChild(WebCore::RenderBox&, WebCore::RenderBlockFlow::MarginInfo&, WebCore::LayoutUnit&, WebCore::LayoutUnit&) 20 0x11bd6125c WebCore::RenderBlockFlow::layoutBlockChildren(bool, WebCore::LayoutUnit&) 21 0x11bd6046c WebCore::RenderBlockFlow::layoutBlock(bool, WebCore::LayoutUnit) 22 0x11bd45954 WebCore::RenderBlock::layout() 23 0x11bd628b0 WebCore::RenderBlockFlow::layoutBlockChild(WebCore::RenderBox&, WebCore::RenderBlockFlow::MarginInfo&, WebCore::LayoutUnit&, WebCore::LayoutUnit&) 24 0x11bd6125c WebCore::RenderBlockFlow::layoutBlockChildren(bool, WebCore::LayoutUnit&) 25 0x11bd6046c WebCore::RenderBlockFlow::layoutBlock(bool, WebCore::LayoutUnit) 26 0x11bd45954 WebCore::RenderBlock::layout() 27 0x11bd628b0 WebCore::RenderBlockFlow::layoutBlockChild(WebCore::RenderBox&, WebCore::RenderBlockFlow::MarginInfo&, WebCore::LayoutUnit&, WebCore::LayoutUnit&) 28 0x11bd6125c WebCore::RenderBlockFlow::layoutBlockChildren(bool, WebCore::LayoutUnit&) 29 0x11bd6046c WebCore::RenderBlockFlow::layoutBlock(bool, WebCore::LayoutUnit) 30 0x11bd45954 WebCore::RenderBlock::layout() 31 0x11bfeca8c WebCore::RenderView::layout()

Attachments
Patch (1.80 KB, patch) 2022-03-02 18:24 PST, alan	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

alan

Comment 1 2022-03-02 18:24:56 PST

Created attachment 453688 [details] Patch

EWS

Comment 2 2022-03-03 03:08:16 PST

Committed r290773 (248017@main): <https://commits.webkit.org/248017@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 453688 [details].

Radar WebKit Bug Importer

Comment 3 2022-03-03 03:09:17 PST

<rdar://problem/89743633>

Note You need to log in before you can comment on or make changes to this bug.