Bug 237360

Summary:

[css-scroll-snap] Improve snapping behavior with incremental directional scrolls

Product:

WebKit

Reporter:

Martin Robinson <mrobinson>

Component:

CSS

Assignee:

Martin Robinson <mrobinson>

Status:

NEW

Severity:

Normal

CC:

clopez, cmarcelo, ews-watchlist, fred.wang, jamesr, luiz, simon.fraser, tonikitoo, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://github.com/web-platform-tests/wpt/pull/33049

Bug Depends on:

237589

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none

Martin Robinson

Reported 2022-03-02 04:17:49 PST

Under certain circumstances, when a snap area covers the viewport the user should be able to scroll into the middle of the area without triggering a snap. An exception to this rule is when doing a directional snap into the large scroll area. In that case, if there is an intermediate snap point (one from another element) that is between the start and end of the large snap area, the scroll should not skip past this intermediate point.

Attachments
Patch (14.09 KB, patch) 2022-03-03 10:27 PST, Martin Robinson	no flags	Details Formatted Diff Diff
Patch (21.38 KB, patch) 2022-03-07 05:51 PST, Martin Robinson	no flags	Details Formatted Diff Diff
Patch (10.91 KB, patch) 2022-04-19 08:38 PDT, Martin Robinson	no flags	Details Formatted Diff Diff
Patch (13.61 KB, patch) 2022-04-20 00:38 PDT, Martin Robinson	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Martin Robinson

Comment 1 2022-03-03 10:27:33 PST

Created attachment 453757 [details] Patch

EWS Watchlist

Comment 2 2022-03-03 10:30:18 PST

This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess

Martin Robinson

Comment 3 2022-03-04 02:58:02 PST

Comment on attachment 453757 [details] Patch Clearing flags. The script used to focus elements for key events needs a bit more work.

Martin Robinson

Comment 4 2022-03-07 05:51:00 PST

Created attachment 453968 [details] Patch

Radar WebKit Bug Importer

Comment 5 2022-03-09 04:18:16 PST

<rdar://problem/90024215>

Martin Robinson

Comment 6 2022-03-09 04:19:44 PST

I have split out parts of this change into bug 237589 and will update the patch here once that lands.