Bug 237358

Summary: Update WPT css-scroll-snap tests
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: Tools / TestsAssignee: Martin Robinson <mrobinson>
Status: REOPENED    
Severity: Normal CC: clopez, ews-watchlist, jenner, rego, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Martin Robinson
Reported 2022-03-02 01:45:48 PST
It's been a while since these tests have been updated.
Attachments
Patch (102.48 KB, patch)
2022-03-02 01:47 PST, Martin Robinson 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (102.48 KB, patch)
2022-03-02 02:56 PST, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Patch (103.15 KB, patch)
2022-03-02 03:04 PST, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Patch (103.71 KB, patch)
2022-03-02 07:02 PST, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Patch (104.50 KB, patch)
2022-03-02 07:20 PST, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Patch (104.64 KB, patch)
2022-03-03 00:54 PST, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2022-03-02 01:47:36 PST
Created attachment 453582 [details] Patch
Martin Robinson
Comment 2 2022-03-02 02:56:41 PST
Created attachment 453583 [details] Patch
Martin Robinson
Comment 3 2022-03-02 03:04:32 PST
Created attachment 453584 [details] Patch
Martin Robinson
Comment 4 2022-03-02 07:02:49 PST
Created attachment 453605 [details] Patch
Manuel Rego Casasnovas
Comment 5 2022-03-02 07:10:41 PST
Comment on attachment 453605 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=453605&action=review r=me, please check that EWSs are green before landing. > LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/css-scroll-snap/scroll-target-margin-005-expected.txt:1 > + I guess you miss a ChangeLog entry for this and next change.
Martin Robinson
Comment 6 2022-03-02 07:20:56 PST
Created attachment 453606 [details] Patch
Martin Robinson
Comment 7 2022-03-03 00:54:08 PST
Created attachment 453706 [details] Patch
EWS
Comment 8 2022-03-03 05:10:58 PST
Committed r290774 (248018@main): <https://commits.webkit.org/248018@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 453706 [details].
Radar WebKit Bug Importer
Comment 9 2022-03-03 05:11:20 PST
<rdar://problem/89747342>
Robert Jenner
Comment 10 2022-03-04 15:36:11 PST
(In reply to EWS from comment #8) > Committed r290774 (248018@main): <https://commits.webkit.org/248018@main> > > All reviewed patches have been landed. Closing bug and clearing flags on > attachment 453706 [details]. This commit caused "imported/w3c/web-platform-tests/css/css-scroll-snap/scroll-target-margin-005.html" to constantly fail on iOS: https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-scroll-snap%2Fscroll-target-margin-005.html TEXT DIFF: -FAIL scroll-margin on input widget assert_between_exclusive: Should honor date input scroll-margin expected a number greater than 4750 and less than 4850 but got 9443 +FAIL scroll-margin on input widget assert_between_exclusive: Should honor date input scroll-margin expected a number greater than 4750 and less than 4850 but got 20000 DIFF URL: https://build.webkit.org/results/Apple-iOS-15-Simulator-Debug-WK2-Tests/r290839%20(1837)/imported/w3c/web-platform-tests/css/css-scroll-snap/scroll-target-margin-005-pretty-diff.html This test started to fail as soon as it was enabled in r290774. Instead of reverting that commit, I have instead marked the test as failing here, since is was slowing down EWS results: https://commits.webkit.org/248084@main I am re-opening this bug so this test failure can be worked on.
Note You need to log in before you can comment on or make changes to this bug.