| Summary: | Remove RemoteVideoSample support from ImageTransferSessionVT | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||
| Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | eric.carlson, ews-watchlist, glenn, hta, jer.noble, philipj, sergio, tommyw, webkit-bug-importer, youennf | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
youenn fablet
2022-03-01 04:14:01 PST
Created attachment 453489 [details]
Patch
Created attachment 453490 [details]
Patch
Created attachment 453491 [details]
Patch
Comment on attachment 453491 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=453491&action=review > Source/WebKit/WebProcess/cocoa/RemoteCaptureSampleManager.cpp:269 > + auto videoFrame = MediaSampleAVFObjC::createImageSample(WTFMove(pixelBuffer), remoteSample.rotation(), remoteSample.mirrored(), remoteSample.time()); As a followup, I think `MediaSampleAVFObjC::createImageSample` is a slightly confusing name. Maybe something like `MediaSampleAVFObjC::createFromPixelBuffer` would be clearer? Committed r290721 (247968@main): <https://commits.webkit.org/247968@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 453491 [details]. |