Bug 23725 – Populate role attribute for List elements correctly.

• Component: Accessibility
• Status: RESOLVED INVALID

[Sankar Aditya Tanguturi]

When a webpage is rendered in webkit, list elements are not exposed and their role attribute is not properly populated.

If same webpage is loaded in Firefox 2.0.0.14, we could observer that list elements are exposed in accessibility tree and also their role attribute is populated as "List".

A patch has already been approved for this fix in bug 20013. I am logging this bug to track that specific issue separately.

I will upload the patch ASAP.

~ Thanks
Sankar.

[Sankar Aditya Tanguturi]

Created attachment 27308 [details]
Patch to expose list elements and populate their role attribute

This is a very simple patch. This patch just includes the fix to expose list elements in the accessibility tree and populate their role attribute properly to List.

~ Thanks
Sankar.

[Mark Rowe (bdash)]

Comment on attachment 27308 [details]
Patch to expose list elements and populate their role attribute

I'm not particularly familiar with this code, but from what I can see we have a AccessibilityList subclass of AccessibilityRenderObject that is used to represent a list.  It looks to me that your changes to AccessibilityRenderObject should not be needed given that AccessibilityList already provides this functionality.

[chris fleizach]

agreed. it seems all this would be taken care of by AccessibilityList.cpp.  

[Mark Rowe (bdash)]

Comment on attachment 27308 [details]
Patch to expose list elements and populate their role attribute

Thanks for the confirmation, Chris.  Marking patch as r-.

[Sankar Aditya Tanguturi]

Thanks for the review comments. I overlooked AccessibilityList.cpp file. But,atleast, role attribute should be set appropriately as "List". I will modify the patch and upload it again.

~ Thanks
Sankar.

(In reply to comment #4)
> (From update of attachment 27308 [details] [review])
> Thanks for the confirmation, Chris.  Marking patch as r-.
> 

[chris fleizach]

in AccessibilityList.h, you'll see

virtual AccessibilityRole roleValue() const { return ListRole; }

so i guess the question is, why doesn't this work on Windows

[Sankar Aditya Tanguturi]

Checked the behavior of webkit without applying my patch. This functionality is already implemented in webkit as specified by Chris. So, closing this bug.

~ Thanks
Sankar.

(In reply to comment #6)
> in AccessibilityList.h, you'll see
> 
> virtual AccessibilityRole roleValue() const { return ListRole; }
> 
> so i guess the question is, why doesn't this work on Windows
>