Bug 237213
| Summary: | CSSStyleDeclaration+PropertyNames.idl: 1 input keys have identical hash values, examine output carefully... | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Michael Catanzaro <mcatanzaro> |
| Component: | CSS | Assignee: | Dan Glastonbury <djg> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | ap, berto, cdumez, cgarcia, darin, gsnedders, koivisto, mcatanzaro, sam, simon.fraser, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | All | ||
| OS: | All | ||
Michael Catanzaro
We should figure out what is going wrong with CSSStyleDeclaration+PropertyNames.idl:
[327/2481] Generating ../../WebCore/DerivedSources/CSSProp...bCore/DerivedSources/CSSStyleDeclaration+PropertyNames.idl
1 input keys have identical hash values, examine output carefully...
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Michael Catanzaro
The generated file says:
// This file is automatically generated from CSSProperties.json by the makeprop.pl script. Do not edit it.
However, we have no clear way to know what "input keys" are problematic here. I've failed to even find the source of this warning. We don't appear to have the strings "identical hash values" or "examine output carefully" anywhere in WebKit, nor even anywhere in Debian (I tried codesearch.debian.net), so it is unclear where this warning is coming from.
Sam Sneddon [:gsnedders]
My guess would be that it's from gperf, but I haven't looked into this.
Radar WebKit Bug Importer
<rdar://problem/89479324>
Alexey Proskuryakov
Somewhat long shot, but any chance for bug 245803 to be caused by this? If so, this seems seriously bad, as it changes observable behavior.
I have no idea about how to "examine output carefully" here.
Michael Catanzaro
The output files are:
${WebCore_DERIVED_SOURCES_DIR}/CSSProperties.json
${WebCore_DERIVED_SOURCES_DIR}/CSSPropertyNames.h
${WebCore_DERIVED_SOURCES_DIR}/CSSPropertyNames.cpp
${WebCore_DERIVED_SOURCES_DIR}/CSSPropertyNames.gperf
${WebCore_DERIVED_SOURCES_DIR}/StyleBuilderGenerated.cpp
${WebCore_DERIVED_SOURCES_DIR}/StylePropertyShorthandFunctions.h
${WebCore_DERIVED_SOURCES_DIR}/StylePropertyShorthandFunctions.cpp
${WebCore_DERIVED_SOURCES_DIR}/CSSStyleDeclaration+PropertyNames.idl
Of which CSSStyleDeclaration+PropertyNames.idl might possibly be related to bug #245803.
Sam Sneddon [:gsnedders]
(In reply to Michael Catanzaro from comment #1)
> The generated file says:
>
> // This file is automatically generated from CSSProperties.json by the
> makeprop.pl script. Do not edit it.
>
> However, we have no clear way to know what "input keys" are problematic
> here. I've failed to even find the source of this warning. We don't appear
> to have the strings "identical hash values" or "examine output carefully"
> anywhere in WebKit, nor even anywhere in Debian (I tried
> codesearch.debian.net), so it is unclear where this warning is coming from.
https://git.savannah.gnu.org/gitweb/?p=gperf.git;a=blob;f=src/search.cc;h=c2459701036d3f7e2dbd35f78fc8d6168c2bd7e6;hb=refs/tags/v3.0.3#l796
Dan Glastonbury
Pull request: https://github.com/WebKit/WebKit/pull/5415
EWS
Committed 255578@main (bd3be165cd17): <https://commits.webkit.org/255578@main>
Reviewed commits have been landed. Closing PR #5415 and removing active labels.