Bug 237186

Summary: Add a feature flag for using general storage directory
Product: WebKit Reporter: Sihui Liu <sihui_liu>
Component: Website StorageAssignee: Sihui Liu <sihui_liu>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, ggaren, sihui_liu, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Sihui Liu
Reported 2022-02-24 23:33:02 PST
...
Attachments
Patch (6.75 KB, patch)
2022-02-24 23:37 PST, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Patch (9.41 KB, patch)
2022-02-25 12:06 PST, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Patch (7.03 KB, patch)
2022-02-25 12:09 PST, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Patch (7.14 KB, patch)
2022-02-26 21:38 PST, Sihui Liu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Sihui Liu
Comment 1 2022-02-24 23:37:25 PST
Created attachment 453176 [details] Patch
Sihui Liu
Comment 2 2022-02-25 12:06:02 PST
Created attachment 453242 [details] Patch
Sihui Liu
Comment 3 2022-02-25 12:09:18 PST
Created attachment 453243 [details] Patch
Chris Dumez
Comment 4 2022-02-25 20:15:15 PST
Comment on attachment 453243 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=453243&action=review > Source/WebKit/ChangeLog:7 > + No explanation in the change log (or in an associated radar if it cannot be public). Makes it hard to understand why we need to do this. > Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreConfiguration.cpp:61 > + m_shouldUseCustomStoragePaths = WebsiteDataStore::defaultShouldUseCustomStoragePaths(); Why isn’t this in the initialization list?
Sihui Liu
Comment 5 2022-02-26 21:27:57 PST
rdar://89521373
Sihui Liu
Comment 6 2022-02-26 21:38:55 PST
Created attachment 453324 [details] Patch
Sihui Liu
Comment 7 2022-02-27 14:59:13 PST
(In reply to Chris Dumez from comment #4) > Comment on attachment 453243 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=453243&action=review > > > Source/WebKit/ChangeLog:7 > > + > > No explanation in the change log (or in an associated radar if it cannot be > public). Makes it hard to understand why we need to do this. Added radar. > > > Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreConfiguration.cpp:61 > > + m_shouldUseCustomStoragePaths = WebsiteDataStore::defaultShouldUseCustomStoragePaths(); > > Why isn’t this in the initialization list? Moved.
EWS
Comment 8 2022-02-27 21:11:10 PST
Committed r290582 (?): <https://commits.webkit.org/r290582> All reviewed patches have been landed. Closing bug and clearing flags on attachment 453324 [details].
Note You need to log in before you can comment on or make changes to this bug.