Bug 237186

Summary: Add a feature flag for using general storage directory
Product: WebKit Reporter: Sihui Liu <sihui_liu>
Component: Website StorageAssignee: Sihui Liu <sihui_liu>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, ggaren, sihui_liu, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Description Sihui Liu 2022-02-24 23:33:02 PST 
...
Comment 1 Sihui Liu 2022-02-24 23:37:25 PST 
Created attachment 453176 [details]
Patch
Comment 2 Sihui Liu 2022-02-25 12:06:02 PST 
Created attachment 453242 [details]
Patch
Comment 3 Sihui Liu 2022-02-25 12:09:18 PST 
Created attachment 453243 [details]
Patch
Comment 4 Chris Dumez 2022-02-25 20:15:15 PST 
Comment on attachment 453243 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453243&action=review

> Source/WebKit/ChangeLog:7
> +

No explanation in the change log (or in an associated radar if it cannot be public). Makes it hard to understand why we need to do this.

> Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreConfiguration.cpp:61
> +    m_shouldUseCustomStoragePaths = WebsiteDataStore::defaultShouldUseCustomStoragePaths();

Why isn’t this in the initialization list?
Comment 5 Sihui Liu 2022-02-26 21:27:57 PST 
rdar://89521373
Comment 6 Sihui Liu 2022-02-26 21:38:55 PST 
Created attachment 453324 [details]
Patch
Comment 7 Sihui Liu 2022-02-27 14:59:13 PST 
(In reply to Chris Dumez from comment #4)
> Comment on attachment 453243 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=453243&action=review
> 
> > Source/WebKit/ChangeLog:7
> > +
> 
> No explanation in the change log (or in an associated radar if it cannot be
> public). Makes it hard to understand why we need to do this.

Added radar.

> 
> > Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreConfiguration.cpp:61
> > +    m_shouldUseCustomStoragePaths = WebsiteDataStore::defaultShouldUseCustomStoragePaths();
> 
> Why isn’t this in the initialization list?

Moved.
Comment 8 EWS 2022-02-27 21:11:10 PST 
Committed r290582 (?): <https://commits.webkit.org/r290582>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 453324 [details].