Bug 237181

Summary: [GTK] The setting WebKitMinimumFontSize is not reset by the testing framework, leading to flaky tests
Product: WebKit Reporter: Arcady Goldmints-Orlov <crzwdjk>
Component: Tools / TestsAssignee: Arcady Goldmints-Orlov <crzwdjk>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, changseok, lmoura, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
A hotfix
none
[fast-cq] Patch none

Arcady Goldmints-Orlov
Reported 2022-02-24 20:28:58 PST
The test fast/forms/validation-message-minimum-font-size.html uses the setting WebKitMinimumFontSize, which on GTK does not appear to be getting reset between tests, leading to failures in tests that run in the same test runner process, which results in test flakiness. The code to set this setting on GTK was introduced by r288666.
Attachments
A hotfix (1.03 KB, patch)
2022-04-03 15:21 PDT, ChangSeok Oh 		no flags
DetailsFormatted DiffDiff
[fast-cq] Patch (1.50 KB, patch)
2022-04-27 11:37 PDT, Arcady Goldmints-Orlov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
ChangSeok Oh
Comment 1 2022-02-28 16:29:08 PST
(In reply to Arcady Goldmints-Orlov from comment #0) > The test fast/forms/validation-message-minimum-font-size.html uses the > setting WebKitMinimumFontSize, which on GTK does not appear to be getting > reset between tests, leading to failures in tests that run in the same test > runner process, which results in test flakiness. The code to set this > setting on GTK was introduced by r288666. May I ask what tests are flaky in particular?
Arcady Goldmints-Orlov
Comment 2 2022-02-28 16:43:10 PST
If you are looking to reproduce it, the command I have been using is: Tools/Scripts/run-webkit-tests --no-new --child-processes=1 --no-show fast/forms/validation-message-minimum-font-size.html fast/text/international
ChangSeok Oh
Comment 3 2022-04-03 15:20:50 PDT
(In reply to Arcady Goldmints-Orlov from comment #2) > If you are looking to reproduce it, the command I have been using is: > > Tools/Scripts/run-webkit-tests --no-new --child-processes=1 --no-show > fast/forms/validation-message-minimum-font-size.html fast/text/international Unfortunately, I could not reproduce the issue in two different Linux distributions: Ubuntu 21.10 and Fedora 35. In my investigation, a WebPreferences instance is ephemeral so each test creates its own WebPreferences rather than sharing one among tests. Would you test if the attached hotfix resolves your issue?
ChangSeok Oh
Comment 4 2022-04-03 15:21:42 PDT
Created attachment 456521 [details] A hotfix
Arcady Goldmints-Orlov
Comment 5 2022-04-27 11:14:04 PDT
This was fixed by r292681, I will remove the line from the TestExpectation.
Arcady Goldmints-Orlov
Comment 6 2022-04-27 11:37:10 PDT
Created attachment 458455 [details] [fast-cq] Patch
EWS
Comment 7 2022-04-27 12:04:23 PDT
Committed r293523 (250054@main): <https://commits.webkit.org/250054@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 458455 [details].
Radar WebKit Bug Importer
Comment 8 2022-04-27 12:05:13 PDT
<rdar://problem/92412612>
Note You need to log in before you can comment on or make changes to this bug.